chore: use styled wrapper instead of Box #6962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 894e600 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/4053 |
github-actions
bot
added
the
integration-tests: failing
|
🔴 ci completed with status |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the Box wrapper with styled() wrapper for three components (Label, Spinner, and Token) in the @primer/styled-react package to fix an issue where the size prop was being overridden by styled-system theme causing unintended styles.
- Refactored Token component from manual sx prop handling to styled-components wrapper
- Simplified Spinner component from Box wrapper to direct styled-components wrapper
- Updated Label component to use styled() instead of Box wrapper
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/styled-react/src/components/Token.tsx | Replaced manual sx prop handling with styled-components wrapper, simplified implementation |
| packages/styled-react/src/components/Spinner.tsx | Changed from Box wrapper to direct styled-components wrapper |
| packages/styled-react/src/components/Label.tsx | Updated to use styled() instead of Box wrapper |
| .changeset/purple-waves-pay.md | Added changeset entry for patch release |
TylerJDev
approved these changes
Oct 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where size=... prop was being overriden by styled-system theme and causing unintended styles
Changelog
Changed
Rollout strategy
Testing & Reviewing
Merge checklist