Skip to content

Conversation

francinelucca
Copy link
Member

Checkbox and RadioGroup share subcomponents. prevent RadioGroup from rewriting slot.

Changelog

Changed

  • declare slot name in CheckboxOrRadioGroup subcomponents file directly, do not rewrite at parent level

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Oct 13, 2025

🦋 Changeset detected

Latest commit: a5b37ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Patch
@primer/styled-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 13, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 13, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-6994 October 13, 2025 14:05 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6994 October 13, 2025 14:14 Inactive
@francinelucca francinelucca marked this pull request as ready for review October 13, 2025 15:05
@francinelucca francinelucca requested a review from a team as a code owner October 13, 2025 15:05
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prevents slot rewriting conflicts between CheckboxGroup and RadioGroup components by declaring slot names directly in the shared CheckboxOrRadioGroup subcomponents instead of rewriting them at the parent level.

  • Moved slot symbol declarations from RadioGroup to individual CheckboxOrRadioGroup subcomponents
  • Updated slot symbol names to use generic component names instead of specific parent component names
  • Removed slot rewriting code from RadioGroup that was overriding the shared subcomponents

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
CheckboxOrRadioGroupValidation.tsx Changed slot symbol from 'CheckboxGroup.Validation' to 'CheckboxOrRadioGroupValidation'
CheckboxOrRadioGroupLabel.tsx Changed slot symbol from 'CheckboxGroup.Label' to 'CheckboxOrRadioGroupLabel'
CheckboxOrRadioGroupCaption.tsx Changed slot symbol from 'CheckboxGroup.Caption' to 'CheckboxOrRadioGroupCaption'
RadioGroup.tsx Removed slot rewriting code that was overriding shared subcomponent slots
.changeset/angry-guests-listen.md Added changeset entry for patch release

@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/4463

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 13, 2025
@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Oct 13, 2025
@francinelucca francinelucca merged commit 701a9d0 into main Oct 13, 2025
43 of 46 checks passed
@francinelucca francinelucca deleted the chore/do-not-rewrite-slot branch October 13, 2025 17:14
@primer primer bot mentioned this pull request Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants