-
Notifications
You must be signed in to change notification settings - Fork 637
chore: prevent slot rewrite #6994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: a5b37ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR prevents slot rewriting conflicts between CheckboxGroup and RadioGroup components by declaring slot names directly in the shared CheckboxOrRadioGroup subcomponents instead of rewriting them at the parent level.
- Moved slot symbol declarations from RadioGroup to individual CheckboxOrRadioGroup subcomponents
- Updated slot symbol names to use generic component names instead of specific parent component names
- Removed slot rewriting code from RadioGroup that was overriding the shared subcomponents
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
CheckboxOrRadioGroupValidation.tsx | Changed slot symbol from 'CheckboxGroup.Validation' to 'CheckboxOrRadioGroupValidation' |
CheckboxOrRadioGroupLabel.tsx | Changed slot symbol from 'CheckboxGroup.Label' to 'CheckboxOrRadioGroupLabel' |
CheckboxOrRadioGroupCaption.tsx | Changed slot symbol from 'CheckboxGroup.Caption' to 'CheckboxOrRadioGroupCaption' |
RadioGroup.tsx | Removed slot rewriting code that was overriding shared subcomponent slots |
.changeset/angry-guests-listen.md | Added changeset entry for patch release |
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/4463 |
🟢 ci completed with status |
Checkbox and RadioGroup share subcomponents. prevent RadioGroup from rewriting slot.
Changelog
Changed
Rollout strategy
Testing & Reviewing
Merge checklist