Skip to content

chore: prevent slot rewrite #6994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2025
Merged

chore: prevent slot rewrite #6994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1a3c47
chore: prevent slot rewrite
francinelucca Oct 13, 2025
524f053
Merge branch 'main' into chore/do-not-rewrite-slot
francinelucca Oct 13, 2025
a5b37ae
Clarify slot rewrite prevention in CheckboxOrRadioGroup
francinelucca Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/angry-guests-listen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

chore: prevent slot rewrite on CheckboxOrRadioGroup subcomponents
4 changes: 0 additions & 4 deletions packages/react/src/RadioGroup/RadioGroup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,3 @@ export default Object.assign(RadioGroup, {
Label: CheckboxOrRadioGroupLabel,
Validation: CheckboxOrRadioGroupValidation,
})

CheckboxOrRadioGroupCaption.__SLOT__ = Symbol('RadioGroup.Caption')
CheckboxOrRadioGroupLabel.__SLOT__ = Symbol('RadioGroup.Label')
CheckboxOrRadioGroupValidation.__SLOT__ = Symbol('RadioGroup.Validation')
2 changes: 1 addition & 1 deletion packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupCaption.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ const CheckboxOrRadioGroupCaption: FCWithSlotMarker<CheckboxOrRadioGroupCaptionP

export default CheckboxOrRadioGroupCaption

CheckboxOrRadioGroupCaption.__SLOT__ = Symbol('CheckboxGroup.Caption')
CheckboxOrRadioGroupCaption.__SLOT__ = Symbol('CheckboxOrRadioGroupCaption')
2 changes: 1 addition & 1 deletion packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupLabel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ const CheckboxOrRadioGroupLabel: FCWithSlotMarker<React.PropsWithChildren<Checkb

export default CheckboxOrRadioGroupLabel

CheckboxOrRadioGroupLabel.__SLOT__ = Symbol('CheckboxGroup.Label')
CheckboxOrRadioGroupLabel.__SLOT__ = Symbol('CheckboxOrRadioGroupLabel')
2 changes: 1 addition & 1 deletion ...ges/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupValidation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ const CheckboxOrRadioGroupValidation: FCWithSlotMarker<

export default CheckboxOrRadioGroupValidation

CheckboxOrRadioGroupValidation.__SLOT__ = Symbol('CheckboxGroup.Validation')
CheckboxOrRadioGroupValidation.__SLOT__ = Symbol('CheckboxOrRadioGroupValidation')
Loading