Skip to content

Conversation

@dmarcey
Copy link
Contributor

@dmarcey dmarcey commented Feb 27, 2020

Adds a <WithPseudoClass /> component that is available in our playroom configuration to make things like sticker sheets where we want to view :hover or :focus states at rest.

Modifies playroom config to allow for use of non-primer components in playroom.

https://primer-components-hppokfo5v.now.sh/playroom//#?code=N4Igxg9gJgpiBcIA8AhCAPABABwLzAG0BmAGkwBYBdAXwD4AdAO001QFcAXDiZgW3wBMdAHIQATrwCGAGyQB6FJ26MGzVgHUAlhwAWABQDOMNlAgBhaZIMGcRk+cvXc9BDogA3GGJeqWLdlw8mPzAQrQAEh5e8oqBKkz+clq6hsamFlYGvhra+nbpjjbY+Q6ZzgiSYByanj4JfgHKwYJ0AIJVNTAxSjzZ8sl5aaXWfQOp9hnWtkOTBuXwAGYQYGwGdWr+sU0hYQBiy6vdcX1JueMFmaoxGKog1EA

Also added a prototype of a <Stickersheet> component that can spread various props / pseudoclasses out to children to reduce some copy/paste when trying to look at a component in its different states.

image

I didn't go full out Cartesian product on these yet, but I could see that potentially being a prop added later on.

https://primer-components-hppokfo5v.now.sh/playroom/#?code=N4Igxg9gJgpiBcIA8BlALgSzAaxgJxQAsYY0ACTNAGxgF4AdEdLXPMoktAQkYD56AdmTJIAwhAC2ABwgCYAtMxz4OpQcOGUaDEACEArmjSyAzo3UapeCFJO1gAbQsaywMlZvwyjKBhMBDACMaKEYAGjIAN38qfRgTLwc0PDiAXTIAXzDnDTcPKS9GaLwMfwVwqJi4hLInEBMJGKoKxip-PABzGEZ0jJzUvqFLExh9KAhRNpMRu0dGeH8wTEjukAj5wggVvBaEADMIMH0zEAGLfiHhJAMjWV4b4wEkAHoHu5zrw0eABRLGvAAnvcvrIXm8BL8MP8gR9wQARMpdPDA25PV4ggQIgRIi4uT6ogDyhioGDkKMeYIxROopJguJEz3E0lk8kUmGUBGIpHpYkkMjkCiUrFUaByWjojAAMkEYFQTjl8rMnJdcu5rAVvCAoOqTIR-OMAO4VaKxeKJZJpTLZFXCPLqwogYqlcprSqmmp1BpNXZtTqrdYgAAezVOmX6g2E9Ku0sCst4MdlLwTVCjImTZECHR0eBgUAAdAAWPjJpMylMfdMQYm0jMQPCwPDiKh17O5vMAJkYZEgzbwrfzRZAqeEyY+z2TPMZfJZgvZwq5aAuLyFKgXFzWIANGCgaEIJgQDgAjAAGdsFgZAA

@dmarcey dmarcey requested review from colebemis and emplums February 27, 2020 13:52
@vercel
Copy link

vercel bot commented Feb 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/gro2iyue9
✅ Preview: https://primer-components-git-withpseudoclass.primer.now.sh

@vercel vercel bot temporarily deployed to Preview February 27, 2020 14:02 Inactive
@dmarcey
Copy link
Contributor Author

dmarcey commented Feb 27, 2020

@colebemis Any issues with the changes to the playroom config? I didn't really want to add this component to primer itself, but wanted a way to expose it to playroom, and it looked like this was the best way to do so.

I also went ahead and re-exported some octicons for usage in playroom (same ones as in our Gatsby live-code-scope.js while I was at it.

Also, if you can think of a better name for the component, I'm all ears 👂👂

@vercel vercel bot temporarily deployed to Preview February 27, 2020 15:31 Inactive
@vercel vercel bot temporarily deployed to Preview February 27, 2020 17:34 Inactive
@emplums
Copy link

emplums commented Mar 17, 2020

@colebemis mind giving this one a review? I think you'd be the best one to take a look!

@emplums emplums removed their request for review March 17, 2020 00:00
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @dmarcey! 👍

@vercel vercel bot temporarily deployed to Preview April 10, 2020 15:13 Inactive
@dmarcey
Copy link
Contributor Author

dmarcey commented Apr 10, 2020

@emplums is this fine to go straight to master, rather than through a release, since it only touches playroom config?

@emplums
Copy link

emplums commented Apr 17, 2020

@dmarcey sorry for the delay, yep this is fine to go straight to master! Feel free to merge 🙌 😸

@vercel vercel bot temporarily deployed to Preview April 17, 2020 15:21 Inactive
@vercel vercel bot temporarily deployed to Preview April 30, 2020 00:45 Inactive
@emplums emplums merged commit 1db268b into master Apr 30, 2020
@emplums emplums deleted the withPseudoClass branch April 30, 2020 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants