Skip to content

Update Dropdown title type #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Update Dropdown title type #704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/content/Dropdown.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Dropdown, Dropdown.Menu, and Dropdown.Item all get `COMMON` system props. Read o
| Name | Type | Default | Description |
| :- | :- | :-: | :- |
| direction | String | 'sw' | Sets the direction of the dropdown menu. |
| title | String | | Sets the text inside of the button |
| title | String or Node | | Sets the text inside of the button, can be either a string or a React node |

#### Dropdown.Item
No additional props.
Expand Down
2 changes: 1 addition & 1 deletion index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ declare module '@primer/components' {

export interface DropdownMenuProps extends CommonProps, Omit<React.HTMLAttributes<HTMLUListElement>, 'color'> {
direction?: string
title: string
title: string | React.ReactNode
}

export const Dropdown: React.FunctionComponent<DropdownProps> & {
Expand Down
2 changes: 1 addition & 1 deletion src/Dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ Dropdown.Item.propTypes = {
Dropdown.defaultProps = {theme}
Dropdown.propTypes = {
children: PropTypes.node,
title: PropTypes.string,
title: PropTypes.oneOfType([PropTypes.string, PropTypes.node]),
...COMMON.propTypes
}

Expand Down