-
Notifications
You must be signed in to change notification settings - Fork 645
Export useAnchoredPosition hook #7066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 0546ca0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR exports the useAnchoredPosition hook and its associated type to make them publicly available for consumers of the @primer/react package. This enables developers to position popovers using the same positioning logic as anchored overlays.
Key changes:
- Exports the
useAnchoredPositionhook andAnchoredPositionHookSettingstype from the package's public API - Adds a changeset documenting this as a minor release
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/index.ts | Adds export statement for useAnchoredPosition hook and its settings type |
| .changeset/five-hats-sleep.md | Documents the change as a minor version bump with description of the new export |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
34b2246 to
efa4e53
Compare
efa4e53 to
cd50ce2
Compare
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/5602 |
|
🔴 ci completed with status |
Changelog
New
useAnchoredPositionutility hook to enable positioning a popover in the same location as an anchored overlayRollout strategy
Testing & Reviewing
Merge checklist