Skip to content

Conversation

@adierkens
Copy link
Contributor

Changelog

New

  • Exports the useAnchoredPosition utility hook to enable positioning a popover in the same location as an anchored overlay

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@adierkens adierkens requested a review from a team as a code owner October 23, 2025 14:58
@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2025

🦋 Changeset detected

Latest commit: 0546ca0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Minor
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR exports the useAnchoredPosition hook and its associated type to make them publicly available for consumers of the @primer/react package. This enables developers to position popovers using the same positioning logic as anchored overlays.

Key changes:

  • Exports the useAnchoredPosition hook and AnchoredPositionHookSettings type from the package's public API
  • Adds a changeset documenting this as a minor release

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
packages/react/src/index.ts Adds export statement for useAnchoredPosition hook and its settings type
.changeset/five-hats-sleep.md Documents the change as a minor version bump with description of the new export

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 23, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@adierkens adierkens force-pushed the adierkens/anchor-position-hook branch from 34b2246 to efa4e53 Compare October 23, 2025 15:00
@adierkens adierkens marked this pull request as draft October 23, 2025 15:00
@github-actions github-actions bot requested a deployment to storybook-preview-7066 October 23, 2025 15:04 Abandoned
@adierkens adierkens force-pushed the adierkens/anchor-position-hook branch from efa4e53 to cd50ce2 Compare October 23, 2025 15:05
@adierkens adierkens marked this pull request as ready for review October 23, 2025 15:05
@github-actions github-actions bot requested a deployment to storybook-preview-7066 October 23, 2025 15:09 Abandoned
@adierkens adierkens added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit c32f726 Oct 24, 2025
42 checks passed
@adierkens adierkens deleted the adierkens/anchor-position-hook branch October 24, 2025 13:15
@primer primer bot mentioned this pull request Oct 24, 2025
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/5602

@primer-integration
Copy link

🔴 ci completed with status failure.

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: failing Changes in this PR cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants