Skip to content

Conversation

@siddharthkp
Copy link
Member

@siddharthkp siddharthkp requested review from a team as code owners November 4, 2025 16:51
@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2025

🦋 Changeset detected

Latest commit: ea2d918

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Patch
@primer/styled-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Nov 4, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated underline prop from the Link component. The prop was already deprecated and developers should use the inline prop instead to specify link type. This is appropriately marked as a major version change since it's a breaking API change.

Reviewed Changes

Copilot reviewed 8 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react/src/Link/Link.tsx Removed underline prop from type definition and destructuring; removed data-underline attribute
packages/react/src/Link/Link.module.css Removed CSS selector for data-underline='true' and updated comment
packages/react/src/Link/Link.stories.tsx Removed underline: false from Playground args
packages/react/src/Link/Link.features.stories.tsx Removed Underline story that demonstrated the deprecated prop
packages/react/src/Link/Link.docs.json Removed reference to the Underline story
packages/react/src/Link/Link.dev.stories.tsx Removed all test cases demonstrating underline prop behavior
e2e/components/Link.test.ts Removed VRT test entry for the Underline story
.playwright/snapshots/*.png Updated VRT snapshots reflecting UI changes from removed test cases
.changeset/swift-queens-smoke.md Documents breaking change with major version bump

Copy link
Contributor

@liuliu-dev liuliu-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot requested a deployment to storybook-preview-7128 November 4, 2025 16:55 Abandoned
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/6200

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 4, 2025
@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Nov 4, 2025
@siddharthkp siddharthkp added this pull request to the merge queue Nov 4, 2025
Merged via the queue into main with commit 4d0f08a Nov 4, 2025
45 of 48 checks passed
@siddharthkp siddharthkp deleted the revert-7125-revert-7021-liuliu/remove-link-underline-prop branch November 4, 2025 17:29
@primer primer bot mentioned this pull request Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants