-
Notifications
You must be signed in to change notification settings - Fork 645
Revert "Revert "Remove deprecated underline prop from Link component"" #7128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "Remove deprecated underline prop from Link component"" #7128
Conversation
siddharthkp
commented
Nov 4, 2025
- Reverts Revert "Remove deprecated underline prop from Link component" #7125
- Brings back Remove deprecated underline prop from Link component #7021
- Case of unfortunate timing, the github-ui fix was already merged but integration PR did not have changes from main
🦋 Changeset detectedLatest commit: ea2d918 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated underline prop from the Link component. The prop was already deprecated and developers should use the inline prop instead to specify link type. This is appropriately marked as a major version change since it's a breaking API change.
Reviewed Changes
Copilot reviewed 8 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/Link/Link.tsx | Removed underline prop from type definition and destructuring; removed data-underline attribute |
| packages/react/src/Link/Link.module.css | Removed CSS selector for data-underline='true' and updated comment |
| packages/react/src/Link/Link.stories.tsx | Removed underline: false from Playground args |
| packages/react/src/Link/Link.features.stories.tsx | Removed Underline story that demonstrated the deprecated prop |
| packages/react/src/Link/Link.docs.json | Removed reference to the Underline story |
| packages/react/src/Link/Link.dev.stories.tsx | Removed all test cases demonstrating underline prop behavior |
| e2e/components/Link.test.ts | Removed VRT test entry for the Underline story |
| .playwright/snapshots/*.png | Updated VRT snapshots reflecting UI changes from removed test cases |
| .changeset/swift-queens-smoke.md | Documents breaking change with major version bump |
liuliu-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/6200 |
|
🟢 ci completed with status |