Skip to content

Conversation

@liuliu-dev
Copy link
Contributor

Closes #7173

Changelog

Removes the unused underline prop from LinkButtonProps in the LinkButton component.

Rollout strategy

  • Patch release

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2025

🦋 Changeset detected

Latest commit: d735b21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 12, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/6728

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 12, 2025
@liuliu-dev liuliu-dev marked this pull request as ready for review November 12, 2025 18:42
@liuliu-dev liuliu-dev requested a review from a team as a code owner November 12, 2025 18:42
Copilot finished reviewing on behalf of liuliu-dev November 12, 2025 18:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the unused underline prop from the LinkButtonProps type definition, cleaning up the API surface by removing a property that was never implemented or used in the LinkButton component.

Key Changes

  • Removed the unused underline?: boolean property from LinkButtonProps type definition
  • Added a changeset documenting this as a patch release

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/Button/types.ts Removes the unused underline property from LinkButtonProps type definition
.changeset/short-lands-create.md Adds changeset entry documenting the removal as a patch release

@@ -0,0 +1,5 @@
---
'@primer/react': patch
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes a prop from a public TypeScript interface, which is technically a breaking change for TypeScript consumers who may have been passing this prop (even though it had no runtime effect). This should be released as a 'minor' version instead of a 'patch' to follow semantic versioning conventions for breaking changes in TypeScript APIs.

Suggested change
'@primer/react': patch
'@primer/react': minor

Copilot uses AI. Check for mistakes.
@primer-integration
Copy link

🟢 ci completed with status success.

Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@liuliu-dev liuliu-dev added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main with commit 9403294 Nov 13, 2025
61 checks passed
@liuliu-dev liuliu-dev deleted the liuliu/remove-unused-underline-prop-from-linkbutton branch November 13, 2025 16:37
@primer primer bot mentioned this pull request Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LinkButton serializes underline to the dom instead of stripping it

3 participants