-
Notifications
You must be signed in to change notification settings - Fork 645
Remove unused underline prop from LinkButtonProps
#7188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused underline prop from LinkButtonProps
#7188
Conversation
🦋 Changeset detectedLatest commit: d735b21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/6728 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the unused underline prop from the LinkButtonProps type definition, cleaning up the API surface by removing a property that was never implemented or used in the LinkButton component.
Key Changes
- Removed the unused
underline?: booleanproperty fromLinkButtonPropstype definition - Added a changeset documenting this as a patch release
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react/src/Button/types.ts | Removes the unused underline property from LinkButtonProps type definition |
| .changeset/short-lands-create.md | Adds changeset entry documenting the removal as a patch release |
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@primer/react': patch | |||
Copilot
AI
Nov 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change removes a prop from a public TypeScript interface, which is technically a breaking change for TypeScript consumers who may have been passing this prop (even though it had no runtime effect). This should be released as a 'minor' version instead of a 'patch' to follow semantic versioning conventions for breaking changes in TypeScript APIs.
| '@primer/react': patch | |
| '@primer/react': minor |
|
🟢 ci completed with status |
francinelucca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Closes #7173
Changelog
Removes the unused
underlineprop fromLinkButtonPropsin the LinkButton component.Rollout strategy
Testing & Reviewing
Merge checklist