Skip to content

Remove unused underline prop from LinkButtonProps #7188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
Merged

Remove unused underline prop from LinkButtonProps #7188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8d2d45
remove type
liuliu-dev Nov 12, 2025
d735b21
changeset
liuliu-dev Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/short-lands-create.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes a prop from a public TypeScript interface, which is technically a breaking change for TypeScript consumers who may have been passing this prop (even though it had no runtime effect). This should be released as a 'minor' version instead of a 'patch' to follow semantic versioning conventions for breaking changes in TypeScript APIs.

Suggested change
'@primer/react': patch
'@primer/react': minor

Copilot uses AI. Check for mistakes.
---

Remove unused `underline` prop from LinkButtonProps.
1 change: 0 additions & 1 deletion packages/react/src/Button/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ export type IconButtonProps = ButtonA11yProps & {

// adopted from React.AnchorHTMLAttributes
export type LinkButtonProps = {
underline?: boolean
download?: string
href?: string
hrefLang?: string
Expand Down
Loading