Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 14, 2025

Closes https://github.com/github/primer/issues/6120

Adds box-shadow: var(--shadow-floating-small) to Popover, aligning it with Dialog and Overlay components.

Before:
Popover displayed with border only, no depth differentiation from page content.

After:
Popover with shadow

Changelog

New

Changed

  • Popover.Content now renders with floating shadow using --shadow-floating-small design token

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Visual regression tests will capture the shadow addition. Existing functionality unchanged.

Merge checklist

Original prompt

Popover should have a shadow using the shadow css variable --shadow-floating-small


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2025

🦋 Changeset detected

Latest commit: 84bacb2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: lukasoppermann <813754+lukasoppermann@users.noreply.github.com>
@lukasoppermann
Copy link
Contributor

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 14, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

Copilot AI changed the title [WIP] Add shadow to popover using CSS variable Add shadow to Popover component Nov 14, 2025
Copilot AI requested a review from lukasoppermann November 14, 2025 07:46
Copilot finished work on behalf of lukasoppermann November 14, 2025 07:46
@github-actions github-actions bot requested a deployment to storybook-preview-7198 November 14, 2025 07:47 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-7198 November 14, 2025 08:02 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-7198 November 14, 2025 08:35 Inactive
@lukasoppermann lukasoppermann added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 14, 2025
Copilot finished reviewing on behalf of lukasoppermann November 14, 2025 09:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a floating shadow to the Popover component to align its visual design with Dialog and Overlay components, improving depth perception and visual hierarchy.

Key Changes:

  • Replaces the border with box-shadow: var(--shadow-floating-small) design token
  • Updates all visual regression test snapshots across themes and color modes

Reviewed Changes

Copilot reviewed 2 out of 29 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/Popover/Popover.module.css Removes border property and adds box-shadow using the --shadow-floating-small design token
.playwright/snapshots/components/Popover.test.ts-snapshots/*.png Updates visual regression test snapshots for all theme variants (light, dark, high-contrast, colorblind, tritanopia, dimmed) to reflect the shadow addition
.changeset/gentle-peas-kick.md Adds changeset documenting the patch-level change

margin-left: auto;
background-color: var(--overlay-bgColor);
border: var(--borderWidth-thin) solid var(--borderColor-default);
border-radius: var(--borderRadius-medium);
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The border property has been removed entirely. According to the PR description, the goal is to add shadow to align with Dialog and Overlay components, but this change removes the existing border. Consider whether the border should be retained alongside the shadow, or if this is intentional. If intentional, the PR description should clearly state that the border is being replaced (not just that shadow is being added).

Suggested change
border-radius: var(--borderRadius-medium);
border-radius: var(--borderRadius-medium);
border: 1px solid var(--borderColor-default);

Copilot uses AI. Check for mistakes.
@lukasoppermann lukasoppermann added this pull request to the merge queue Nov 14, 2025
github-merge-queue bot pushed a commit that referenced this pull request Nov 14, 2025
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lukasoppermann <813754+lukasoppermann@users.noreply.github.com>
Co-authored-by: Lukas Oppermann <lukasoppermann@github.com>
@lukasoppermann lukasoppermann removed this pull request from the merge queue due to a manual request Nov 14, 2025
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/6889

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh labels Nov 14, 2025
@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Nov 14, 2025
@lukasoppermann lukasoppermann added this pull request to the merge queue Nov 14, 2025
Merged via the queue into main with commit b1a8acc Nov 14, 2025
58 checks passed
@lukasoppermann lukasoppermann deleted the copilot/add-popover-shadow branch November 14, 2025 11:04
@primer primer bot mentioned this pull request Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants