-
Notifications
You must be signed in to change notification settings - Fork 646
Add shadow to Popover component #7198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 84bacb2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: lukasoppermann <813754+lukasoppermann@users.noreply.github.com>
|
This closes https://github.com/github/primer/issues/6120 |
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a floating shadow to the Popover component to align its visual design with Dialog and Overlay components, improving depth perception and visual hierarchy.
Key Changes:
- Replaces the border with
box-shadow: var(--shadow-floating-small)design token - Updates all visual regression test snapshots across themes and color modes
Reviewed Changes
Copilot reviewed 2 out of 29 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/react/src/Popover/Popover.module.css |
Removes border property and adds box-shadow using the --shadow-floating-small design token |
.playwright/snapshots/components/Popover.test.ts-snapshots/*.png |
Updates visual regression test snapshots for all theme variants (light, dark, high-contrast, colorblind, tritanopia, dimmed) to reflect the shadow addition |
.changeset/gentle-peas-kick.md |
Adds changeset documenting the patch-level change |
| margin-left: auto; | ||
| background-color: var(--overlay-bgColor); | ||
| border: var(--borderWidth-thin) solid var(--borderColor-default); | ||
| border-radius: var(--borderRadius-medium); |
Copilot
AI
Nov 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The border property has been removed entirely. According to the PR description, the goal is to add shadow to align with Dialog and Overlay components, but this change removes the existing border. Consider whether the border should be retained alongside the shadow, or if this is intentional. If intentional, the PR description should clearly state that the border is being replaced (not just that shadow is being added).
| border-radius: var(--borderRadius-medium); | |
| border-radius: var(--borderRadius-medium); | |
| border: 1px solid var(--borderColor-default); |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lukasoppermann <813754+lukasoppermann@users.noreply.github.com> Co-authored-by: Lukas Oppermann <lukasoppermann@github.com>
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/6889 |
|
🟢 ci completed with status |
Closes https://github.com/github/primer/issues/6120
Adds
box-shadow: var(--shadow-floating-small)to Popover, aligning it with Dialog and Overlay components.Before:
Popover displayed with border only, no depth differentiation from page content.
After:

Changelog
New
Changed
Popover.Contentnow renders with floating shadow using--shadow-floating-smalldesign tokenRemoved
Rollout strategy
Testing & Reviewing
Visual regression tests will capture the shadow addition. Existing functionality unchanged.
Merge checklist
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.