Skip to content

Add shadow to Popover component #7198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 14, 2025
Merged

Add shadow to Popover component #7198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ad09ef
Initial plan
Copilot Nov 14, 2025
316d36f
Add shadow to Popover using --shadow-floating-small CSS variable
Copilot Nov 14, 2025
e2eb452
add changesert
lukasoppermann Nov 14, 2025
84bacb2
test(vrt): update snapshots
lukasoppermann Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gentle-peas-kick.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Popover: add missing shadow
Binary file modified ...over.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-dimmed-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...r.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ponents/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...over.test.ts-snapshots/Popover-Close-On-Click-Outside-dark-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ver.test.ts-snapshots/Popover-Close-On-Click-Outside-light-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ....test.ts-snapshots/Popover-Close-On-Click-Outside-light-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...onents/Popover.test.ts-snapshots/Popover-Close-On-Click-Outside-light-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ver.test.ts-snapshots/Popover-Close-On-Click-Outside-light-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../components/Popover.test.ts-snapshots/Popover-Default-dark-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...hots/components/Popover.test.ts-snapshots/Popover-Default-dark-dimmed-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...mponents/Popover.test.ts-snapshots/Popover-Default-dark-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...t/snapshots/components/Popover.test.ts-snapshots/Popover-Default-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../components/Popover.test.ts-snapshots/Popover-Default-dark-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...components/Popover.test.ts-snapshots/Popover-Default-light-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ponents/Popover.test.ts-snapshots/Popover-Default-light-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../snapshots/components/Popover.test.ts-snapshots/Popover-Default-light-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...components/Popover.test.ts-snapshots/Popover-Default-light-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...mponents/Popover.test.ts-snapshots/Popover-Playground-dark-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...s/components/Popover.test.ts-snapshots/Popover-Playground-dark-dimmed-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...nents/Popover.test.ts-snapshots/Popover-Playground-dark-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...napshots/components/Popover.test.ts-snapshots/Popover-Playground-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...mponents/Popover.test.ts-snapshots/Popover-Playground-dark-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ponents/Popover.test.ts-snapshots/Popover-Playground-light-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ents/Popover.test.ts-snapshots/Popover-Playground-light-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...apshots/components/Popover.test.ts-snapshots/Popover-Playground-light-linux.png
View file
Open in desktop
Binary file modified ...ponents/Popover.test.ts-snapshots/Popover-Playground-light-tritanopia-linux.png
View file
Open in desktop
2 changes: 1 addition & 1 deletion packages/react/src/Popover/Popover.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
margin-right: auto;
margin-left: auto;
background-color: var(--overlay-bgColor);
border: var(--borderWidth-thin) solid var(--borderColor-default);
border-radius: var(--borderRadius-medium);
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The border property has been removed entirely. According to the PR description, the goal is to add shadow to align with Dialog and Overlay components, but this change removes the existing border. Consider whether the border should be retained alongside the shadow, or if this is intentional. If intentional, the PR description should clearly state that the border is being replaced (not just that shadow is being added).

Suggested change
border-radius: var(--borderRadius-medium);
border-radius: var(--borderRadius-medium);
border: 1px solid var(--borderColor-default);

Copilot uses AI. Check for mistakes.
box-shadow: var(--shadow-floating-small);

/* Carets */
&::before,
Expand Down
Loading