-
Notifications
You must be signed in to change notification settings - Fork 645
Update permissions to include admin access #7205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the GitHub workflow permissions for the .skip-integration-checks command to include admin access in addition to write access. The change modifies a critical security parameter that controls who can override status checks via issue comments.
Key Changes:
- Modified the
permissionsparameter fromwriteto'write,admin'for the issue comment command step in the status checks workflow
| allowed_contexts: pull_request | ||
| # Note: this permission step is _critical_ to make sure only maintainers can run the command | ||
| permissions: write | ||
| permissions: 'write,admin' |
Copilot
AI
Nov 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The permissions parameter is being changed from write to 'write,admin'. This change appears to be logically inconsistent with the comment above stating this is "critical to make sure only maintainers can run the command."
In GitHub's permission model, write permission is a lower privilege level than admin. If the goal is to restrict the command to maintainers only, adding admin to the list makes the restriction less effective, not more, since anyone with write access can already run the command.
If the intent is to restrict this to admin/maintainer access only, the permissions should be set to just 'admin' or 'maintain,admin' (excluding write). If the intent is to allow both write and admin users, then the comment should be updated to reflect this broader access level.
| permissions: 'write,admin' | |
| permissions: 'maintain,admin' |
It seems like I have to explicitly set the permissions here to include admin 😓