Skip to content

Update permissions to include admin access #7205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
+1 −1
Merged

Update permissions to include admin access #7205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/status-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
command: '.skip-integration-checks'
allowed_contexts: pull_request
# Note: this permission step is _critical_ to make sure only maintainers can run the command
permissions: write
permissions: 'write,admin'
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permissions parameter is being changed from write to 'write,admin'. This change appears to be logically inconsistent with the comment above stating this is "critical to make sure only maintainers can run the command."

In GitHub's permission model, write permission is a lower privilege level than admin. If the goal is to restrict the command to maintainers only, adding admin to the list makes the restriction less effective, not more, since anyone with write access can already run the command.

If the intent is to restrict this to admin/maintainer access only, the permissions should be set to just 'admin' or 'maintain,admin' (excluding write). If the intent is to allow both write and admin users, then the comment should be updated to reflect this broader access level.

Suggested change
permissions: 'write,admin'
permissions: 'maintain,admin'

Copilot uses AI. Check for mistakes.
- name: Override status checks for issue comment
if: ${{ github.event_name == 'issue_comment' && steps.command.outputs.continue == 'true' }}
run: |
Expand Down
Loading