Update Dropdown type & add accent color to theme #722
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues brought up by another GitHub team:
Dropdown
titletype definition is clashing with theCommonPropstypes that it extends. It was also onDropdownMenuwhen it should have just been onDropdown.BaseTypesextendsReact.Props<any>and adds thetitleattribute as an acceptable type. I'm honestly not sure whytitleis included inBaseTypes🤔 but because it's set as only astringit conflicts with thetitleprop inDropdown. I ended up needing to redefine all the types we want fromBaseTypesandCommonTypeson Dropdown to get around this.Changed the theme call in
UnderlineNavto accesscolors.accentinstead ofcolors.orange[5]to allow users of the component to override this color if needed by changing theaccentcolor in the theme