-
Notifications
You must be signed in to change notification settings - Fork 646
Center align header and description for BlankSlate #7239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 6105520 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
|
Uh oh! @lukasoppermann, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:
Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR centers the text alignment for the header and description elements in the BlankSlate component by adding text-align: center; to the CSS module. This complements the existing grid-based centering of the container and ensures that text content within these elements is also centered.
- Adds
text-align: center;CSS property to.Headingand.Descriptionclasses in the BlankSlate component - Properly documented as a patch release in the changeset file
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/Blankslate/Blankslate.module.css | Adds text-align: center; to the shared .Heading, .Description CSS rule to center the text content within these elements |
| .changeset/great-paws-swim.md | Documents this change as a patch release for @primer/react |
Closes https://github.com/github/primer/issues/6066
Changelog
Header and description of BlankSlate are now centered
Rollout strategy
Testing & Reviewing
Merge checklist