Skip to content

WIP: BorderBox and Popover bug fixes #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

WIP: BorderBox and Popover bug fixes #738

wants to merge 6 commits into from

Conversation

@BinaryMuse
Copy link
Contributor

@BinaryMuse BinaryMuse commented Mar 31, 2020

Bugfixes:

  • Allow BorderBox to have its border color changed
  • Make borderColor for Popover affect caret

Version change: patch

Merge checklist

  • Added or updated TypeScript definitions (index.d.ts) if necessary
  • Added/updated documentation

@BinaryMuse BinaryMuse requested a review from emplums March 31, 2020 16:50
@vercel
Copy link

vercel bot commented Mar 31, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-components/5oje98gqj
✅ Preview: https://primer-components-git-mkt-bugfix-borderbox-popover.primer.now.sh

@BinaryMuse BinaryMuse changed the title Mkt/bugfix borderbox popover BorderBox and Popover bug fixes Mar 31, 2020
@vercel vercel bot temporarily deployed to Preview March 31, 2020 16:53 Inactive
@emplums emplums added the patch release bug fixes, docs, housekeeping label Mar 31, 2020
@vercel vercel bot temporarily deployed to Preview April 1, 2020 20:36 Inactive
@vercel vercel bot temporarily deployed to Preview April 1, 2020 20:45 Inactive
@BinaryMuse BinaryMuse added status: wip patch release bug fixes, docs, housekeeping and removed patch release bug fixes, docs, housekeeping labels Apr 1, 2020
@BinaryMuse BinaryMuse changed the title BorderBox and Popover bug fixes WIP: BorderBox and Popover bug fixes Apr 1, 2020
@BinaryMuse
Copy link
Contributor Author

BinaryMuse commented Apr 17, 2020

Closing in favor of #761

@BinaryMuse BinaryMuse closed this Apr 17, 2020
@BinaryMuse BinaryMuse deleted the mkt/bugfix-borderbox-popover branch April 17, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emplums emplums Awaiting requested review from emplums

Assignees

No one assigned

Labels

patch release bug fixes, docs, housekeeping status: wip

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BinaryMuse @emplums