Skip to content

Conversation

@emplums
Copy link

@emplums emplums commented Apr 10, 2020

This PR makes the tweaks listed out in #731

  • Update selected style for primary and outline box shadow to 2px instead of 1px
  • Update UnderlineNav & SideNav states (removed bar on the left on hover/focus)
  • SideNav should have had a white background, but it was grey so I updated that
  • The grey background hover on SideNav items was overlapping the border radius of the container, so I added border radius to the first and last SideNav items
  • Fix SelectMenu tab styles
  • disabled state for buttons with color icon
  • Change back the text in labels and topic tags from font-weight 500 to 400
  • Add label colors to the theme
  • Spacing between select menu header and select menu tabs was mistakingly set as 24px. I have no changed it to 16px.
  • Update blue text in Links, Outline button to blue[5]
  • A bunch of button tweaks: https://github.com/github/design-systems/issues/770#issuecomment-605783773

Notes

  • I added the label colors to the theme so that folks can pull from the theme if they'd like to use them, but we might want to think about whether or not we want to add some kind of colorScheme prop in the future to make using these easier.

  • I removed primer-colors and primer-typography and moved over to @primer/primitives

  • I had one question for @auareyou about the active/selected/hover state for SideNav that I left in the comments

Merge checklist

  • Added or updated TypeScript definitions (index.d.ts) if necessary
  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@vercel
Copy link

vercel bot commented Apr 10, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/d8sslk3qx
✅ Preview: https://primer-components-git-refresh.primer.now.sh

@emplums emplums requested review from BinaryMuse and auareyou April 10, 2020 23:28
@emplums emplums added the minor release new features label Apr 10, 2020
Copy link
Contributor

@BinaryMuse BinaryMuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add, looks great! Thanks for replacing the old primitives.

Co-Authored-By: Cole Bemis <colebemis@github.com>
@vercel vercel bot temporarily deployed to Preview April 14, 2020 20:24 Inactive
@vercel vercel bot temporarily deployed to Preview April 14, 2020 20:28 Inactive
@vercel vercel bot temporarily deployed to Preview April 14, 2020 20:28 Inactive
@emplums
Copy link
Author

emplums commented Apr 14, 2020

Going to release this without the Avatar changes as @colinkeany mentioned it will be a bit more complicated than just adjusting the border radius across the board. We can do this in a different PR/release.

@vercel vercel bot temporarily deployed to Preview April 14, 2020 20:37 Inactive
@emplums
Copy link
Author

emplums commented Apr 23, 2020

Going to do the Flash updates in a separate branch as well, as we should probably do an API refactor of Flash to use standard icons for success/failure/warn

@vercel vercel bot temporarily deployed to Preview April 23, 2020 20:15 Inactive
@emplums emplums changed the base branch from master to release-19.0.0 April 23, 2020 22:46
@vercel vercel bot temporarily deployed to Preview April 23, 2020 23:29 Inactive
@emplums emplums changed the base branch from release-19.0.0 to minor April 23, 2020 23:33
@emplums emplums merged commit aea49fa into minor Apr 23, 2020
@emplums emplums deleted the refresh branch April 23, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor release new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants