-
Notifications
You must be signed in to change notification settings - Fork 645
More Visual Refresh Tweaks #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/d8sslk3qx |
BinaryMuse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add, looks great! Thanks for replacing the old primitives.
Co-Authored-By: Cole Bemis <colebemis@github.com>
|
Going to release this without the Avatar changes as @colinkeany mentioned it will be a bit more complicated than just adjusting the border radius across the board. We can do this in a different PR/release. |
|
Going to do the Flash updates in a separate branch as well, as we should probably do an API refactor of Flash to use standard icons for success/failure/warn |
This reverts commit 97f8a57.
This PR makes the tweaks listed out in #731 ✨
Notes
I added the label colors to the theme so that folks can pull from the theme if they'd like to use them, but we might want to think about whether or not we want to add some kind of
colorSchemeprop in the future to make using these easier.I removed
primer-colorsandprimer-typographyand moved over to@primer/primitivesI had one question for @auareyou about the active/selected/hover state for SideNav that I left in the comments
Merge checklist
index.d.ts) if necessaryTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.