Skip to content

Conversation

@BinaryMuse
Copy link
Contributor

@BinaryMuse BinaryMuse commented Apr 14, 2020

React Hooks dependencies can sometimes be difficult to get right; it's easy to change something without changing the deps, leading to weird, inexplicable bugs.

  • 0b9bf16 adds the hooks linter plugin
  • 38fbd42 enables it and sets the failure type to "error"
  • 448b73e cleans up the lint errors

@vercel
Copy link

vercel bot commented Apr 14, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-components/lm1mmd0hl
✅ Preview: https://primer-components-git-mkt-hooks-linting.primer.now.sh

@vercel vercel bot temporarily deployed to Preview April 14, 2020 03:41 Inactive
@BinaryMuse BinaryMuse marked this pull request as ready for review April 14, 2020 16:40
Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 thanks for adding this!

@BinaryMuse BinaryMuse changed the base branch from master to release-18.0.0 April 14, 2020 17:59
@BinaryMuse BinaryMuse merged commit 691687f into release-18.0.0 Apr 14, 2020
@emplums emplums deleted the mkt/hooks-linting branch September 16, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants