SegmentedControl: remove the wrong aria-label in storybook#7603
SegmentedControl: remove the wrong aria-label in storybook#7603liuliu-dev wants to merge 1 commit intomainfrom
Conversation
|
There was a problem hiding this comment.
Pull request overview
Updates the SegmentedControl Storybook feature story to avoid overriding the buttons’ accessible names with redundant aria-labels, aligning the example with expected accessibility behavior (notably for counter labels) and addressing the referenced audit issue.
Changes:
- Removed per-button
aria-labelprops from the “WithCounterLabels” SegmentedControl story. - Simplified the JSX for the counter-label buttons to rely on visible text (and CounterLabel’s screen-reader text) for accessible naming.
Related issue: https://github.com/github/accessibility-audits/issues/14898
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist