Remove design-reviewers as codeowners for snapshots#7650
Merged
siddharthkp merged 2 commits intomainfrom Mar 11, 2026
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates repository ownership rules to adjust reviewer requirements for Playwright component snapshots.
Changes:
- Removes
@primer/design-reviewersownership from.playwright/snapshots/components - Leaves snapshots owned only by
@primer/engineer-reviewers(matching the global*rule)
liuliu-dev
approved these changes
Mar 10, 2026
lukasoppermann
approved these changes
Mar 11, 2026
francinelucca
approved these changes
Mar 11, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was very useful when we had more designers that were able to act as a quality gate. Now it's just one person reviewing all snapshot changes, we can't expect them to have context for every change that happens.
Removing required reviewer, rip.
Tagging @lukasoppermann for signoff
Rollout strategy