Skip to content

Remove design-reviewers as codeowners for snapshots#7650

Merged
siddharthkp merged 2 commits intomainfrom
remove-design-reviewers
Mar 11, 2026
Merged

Remove design-reviewers as codeowners for snapshots#7650
siddharthkp merged 2 commits intomainfrom
remove-design-reviewers

Conversation

@siddharthkp
Copy link
Copy Markdown
Member

@siddharthkp siddharthkp commented Mar 10, 2026

This was very useful when we had more designers that were able to act as a quality gate. Now it's just one person reviewing all snapshot changes, we can't expect them to have context for every change that happens.

Removing required reviewer, rip.

Tagging @lukasoppermann for signoff

Rollout strategy

  • None

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 10, 2026

⚠️ No Changeset found

Latest commit: 19128ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp marked this pull request as ready for review March 10, 2026 22:26
@siddharthkp siddharthkp requested a review from a team as a code owner March 10, 2026 22:26
@github-actions github-actions Bot added the staff Author is a staff member label Mar 10, 2026
@siddharthkp siddharthkp added skip changeset This change does not need a changelog integration-tests: skipped manually Changes in this PR do not require an integration test labels Mar 10, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates repository ownership rules to adjust reviewer requirements for Playwright component snapshots.

Changes:

  • Removes @primer/design-reviewers ownership from .playwright/snapshots/components
  • Leaves snapshots owned only by @primer/engineer-reviewers (matching the global * rule)

Comment thread CODEOWNERS Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@siddharthkp siddharthkp enabled auto-merge March 11, 2026 21:10
@siddharthkp siddharthkp added this pull request to the merge queue Mar 11, 2026
Merged via the queue into main with commit 6e3977b Mar 11, 2026
53 checks passed
@siddharthkp siddharthkp deleted the remove-design-reviewers branch March 11, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants