Skip to content

Remove link underline effect on hover for Link and Button variant link#7676

Open
Copilot wants to merge 4 commits intomainfrom
copilot/remove-link-underline-effect
Open

Remove link underline effect on hover for Link and Button variant link#7676
Copilot wants to merge 4 commits intomainfrom
copilot/remove-link-underline-effect

Conversation

Copy link
Contributor

Copilot AI commented Mar 18, 2026

  • Explore ButtonBase.module.css and Link.module.css to understand current structure
  • Add &:hover { text-decoration: none; } under &[data-no-visuals] in ButtonBase.module.css
  • Add &:hover { text-decoration: none; } under [data-a11y-link-underlines='true'] &:where([data-inline='true']) in Link.module.css
  • Add changeset for the change
  • Lint and format changed files
  • Run build and tests to validate (all 2324 tests pass)
  • Code review and security checks
  • Create PR (Remove link underline effect on hover for Link and Button variant link #7676)
  • Add update snapshots label (noted in PR description — requires maintainer to add)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: HiroAgustin <1458873+HiroAgustin@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2026

🦋 Changeset detected

Latest commit: 2bb322c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI requested a review from HiroAgustin March 18, 2026 13:01
@HiroAgustin HiroAgustin added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 18, 2026
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 18, 2026
@github-actions
Copy link
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 18, 2026
@github-actions github-actions bot temporarily deployed to storybook-preview-7676 March 18, 2026 13:33 Inactive
@HiroAgustin HiroAgustin marked this pull request as ready for review March 18, 2026 13:40
@HiroAgustin HiroAgustin requested a review from a team as a code owner March 18, 2026 13:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates link-underlining behavior when the data-a11y-link-underlines="true" preference is enabled, and refreshes VRT snapshots to match.

Changes:

  • Adjust Link (inline) underline styling under the a11y underline preference, including hover behavior.
  • Adjust Button variant="link" underline styling under the a11y underline preference (notably the data-no-visuals case).
  • Update Playwright visual snapshots and add a patch changeset.

Reviewed changes

Copilot reviewed 3 out of 21 changed files in this pull request and generated 2 comments.

File Description
packages/react/src/Link/Link.module.css Adds hover override under a11y underline preference for inline links
packages/react/src/Button/ButtonBase.module.css Adds hover override under a11y underline preference for link-variant buttons with data-no-visuals
.playwright/snapshots/components/Link.test.ts-snapshots/* Updates VRT baselines for link hover/focus states across themes/modes
.changeset/remove-link-underline-on-hover.md Declares a patch release note for the styling change

You can also share your feedback on Copilot code review. Take the survey.

@HiroAgustin
Copy link
Contributor

Validated on deployed storybook:

Screen.Recording.2026-03-18.at.14.45.57.mov
Screen.Recording.2026-03-18.at.14.46.15.mov

@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/16539

@primer-integration
Copy link

Integration test results from github/github-ui:

Passed  CI   Passed
Passed  VRT   Passed
Passed  Projects   Passed

All checks passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants