feat: add displayInViewport option to SelectPanel by francinelucca · Pull Request #7699 · primer/react

francinelucca · 2026-03-25T00:49:25Z

Towards https://github.com/github/issues/issues/20714

Changelog

New

Changed

Removed

Rollout strategy

Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Added/updated tests
Added/updated documentation
Added/updated previews (Storybook)
Changes are SSR compatible
Tested in Chrome
Tested in Firefox
Tested in Safari
Tested in Edge
(GitHub staff only) Integration tests pass at github/github-ui (Learn more about how to run integration tests)

…lity

changeset-bot · 2026-03-25T00:49:34Z

🦋 Changeset detected

Latest commit: fd3aa8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-03-25T00:49:59Z

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

Copilot

Pull request overview

Adds a new displayInViewport option to SelectPanel so consumers can opt into AnchoredOverlay’s “fit within viewport when possible” positioning behavior (useful for constrained layouts like dialogs).

Changes:

Extend SelectPanelProps to include displayInViewport and forward it to AnchoredOverlay.
Document the new prop in SelectPanel.docs.json.
Add a changeset for a minor @primer/react release noting the new prop.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
packages/react/src/SelectPanel/SelectPanel.tsx	Plumbs `displayInViewport` through SelectPanel’s public API into the underlying AnchoredOverlay.
packages/react/src/SelectPanel/SelectPanel.docs.json	Adds documentation entry for the new `displayInViewport` prop.
.changeset/select-panel-display-in-viewport.md	Declares a minor release for the new SelectPanel prop.

Copilot · 2026-03-25T01:03:59Z

packages/react/src/SelectPanel/SelectPanel.tsx

        pinPosition={!height}
        className={classes.Overlay}
        displayCloseButton={showXCloseIcon}
        closeButtonProps={closeButtonProps}
+        displayInViewport={displayInViewport}


New displayInViewport behavior is being surfaced on SelectPanel, but there’s no unit test asserting the prop is forwarded to AnchoredOverlay / getAnchoredPosition. Since SelectPanel already has extensive tests, please add a targeted test that renders SelectPanel with displayInViewport={true} and verifies the anchored positioning logic receives displayInViewport: true (e.g., by mocking @primer/behaviors like ActionMenu does).

@copilot open a new pull request to apply changes based on this feedback

packages/react/src/SelectPanel/SelectPanel.docs.json

…panel

Copilot · 2026-03-25T15:52:37Z

@francinelucca I've opened a new pull request, #7702, to work on those changes. Once the pull request is ready, I'll request review from you.

…nel (#7702) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>

…panel

primer-integration · 2026-03-25T16:12:29Z

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/16977

primer-integration · 2026-03-25T16:59:01Z

Integration test results from github/github-ui:

CI Waiting
VRT Passed
Projects Waiting

primer-integration · 2026-03-25T16:59:01Z

Integration test results from github/github-ui:

CI Waiting
VRT Running
Projects Waiting

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>

feat: add displayInViewport option to SelectPanel for improved visibi…

3e65a46

…lity

francinelucca changed the title ~~feat: add displayInViewport option to SelectPanel for improved visibi…~~ feat: add displayInViewport option to SelectPanel Mar 25, 2026

github-actions bot added the staff Author is a staff member label Mar 25, 2026

github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 25, 2026

francinelucca added 2 commits March 24, 2026 20:50

Add changeset

fd4a28d

add changeset

bfcf0df

github-actions bot requested a deployment to storybook-preview-7699 March 25, 2026 00:54 Abandoned

francinelucca marked this pull request as ready for review March 25, 2026 01:01

francinelucca requested a review from a team as a code owner March 25, 2026 01:01

francinelucca requested review from Copilot and llastflowers March 25, 2026 01:01

francinelucca changed the title ~~feat: add displayInViewport option to SelectPanel~~ [DO NOT MERGE] feat: add displayInViewport option to SelectPanel Mar 25, 2026

francinelucca added the do not merge label Mar 25, 2026

Copilot started reviewing on behalf of francinelucca March 25, 2026 01:01 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

francinelucca deployed to github-pages March 25, 2026 01:04 — with GitHub Actions View deployment

github-actions bot temporarily deployed to storybook-preview-7699 March 25, 2026 01:04 Inactive

francinelucca changed the title ~~[DO NOT MERGE] feat: add displayInViewport option to SelectPanel~~ feat: add displayInViewport option to SelectPanel Mar 25, 2026

francinelucca removed the do not merge label Mar 25, 2026

Merge branch 'main' into chore/add-displayinviewport-option-to-select…

0d8d2db

…panel

Copilot AI mentioned this pull request Mar 25, 2026

[WIP] [WIP] Address feedback on displayInViewport option for SelectPanel #7702

Merged

francinelucca deployed to github-pages March 25, 2026 16:01 — with GitHub Actions View deployment

github-actions bot temporarily deployed to storybook-preview-7699 March 25, 2026 16:02 Inactive

Copilot AI and others added 2 commits March 25, 2026 12:02

[WIP] [WIP] Address feedback on displayInViewport option for SelectPa…

1f95f3e

…nel (#7702) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>

Merge branch 'main' into chore/add-displayinviewport-option-to-select…

fd3aa8c

…panel

github-actions bot requested a deployment to storybook-preview-7699 March 25, 2026 16:07 Abandoned

francinelucca deployed to github-pages March 25, 2026 16:17 — with GitHub Actions View deployment

github-actions bot deployed to storybook-preview-7699 March 25, 2026 16:17 View deployment

TylerJDev approved these changes Mar 25, 2026

View reviewed changes

francinelucca added the integration-tests: skipped manually Changes in this PR do not require an integration test label Mar 25, 2026

francinelucca added this pull request to the merge queue Mar 25, 2026

Merged via the queue into main with commit 1505d9b Mar 25, 2026
65 of 67 checks passed

francinelucca deleted the chore/add-displayinviewport-option-to-selectpanel branch March 25, 2026 17:07

primer bot mentioned this pull request Mar 25, 2026

Release tracking #7701

Open

francinelucca added a commit that referenced this pull request Mar 25, 2026

feat: add displayInViewport option to SelectPanel (#7699)

42712b0

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add displayInViewport option to SelectPanel#7699

feat: add displayInViewport option to SelectPanel#7699
francinelucca merged 6 commits intomainfrom
chore/add-displayinviewport-option-to-selectpanel

francinelucca commented Mar 25, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 25, 2026

Uh oh!

francinelucca Mar 25, 2026

Uh oh!

Uh oh!

Copilot AI commented Mar 25, 2026

Uh oh!

primer-integration bot commented Mar 25, 2026

Uh oh!

primer-integration bot commented Mar 25, 2026

Uh oh!

primer-integration bot commented Mar 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

francinelucca commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

New

Changed

Removed

Rollout strategy

Testing & Reviewing

Merge checklist

Uh oh!

changeset-bot bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Mar 25, 2026

⚠️ Action required

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

francinelucca Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Mar 25, 2026

Uh oh!

primer-integration bot commented Mar 25, 2026

Uh oh!

primer-integration bot commented Mar 25, 2026

Uh oh!

primer-integration bot commented Mar 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

francinelucca commented Mar 25, 2026 •

edited

Loading

changeset-bot bot commented Mar 25, 2026 •

edited

Loading