Skip to content

feat: implement ADR-023 Part 1#7724

Merged
francinelucca merged 48 commits intomainfrom
chore/implement-adr-023
Apr 22, 2026
Merged

feat: implement ADR-023 Part 1#7724
francinelucca merged 48 commits intomainfrom
chore/implement-adr-023

Conversation

@francinelucca
Copy link
Copy Markdown
Member

@francinelucca francinelucca commented Apr 2, 2026

Towards https://github.com/github/primer/issues/6497

Adds data-component attribute (see ADR) for:

  • ActionBar
  • ActionList
  • Button
  • FilteredActionList
  • Link
  • LinkButton
  • Pagination
  • SelectPanel
  • Table
  • TextInput
  • TextInputWithTokens
  • TooltipV2

Changelog

New

  • stable selectors for listed components
  • tests for stable selectors added

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 2, 2026

🦋 Changeset detected

Latest commit: b8dc78b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

Comment thread packages/react/src/ActionBar/ActionBar.tsx Outdated
@github-actions github-actions Bot temporarily deployed to storybook-preview-7724 April 2, 2026 03:31 Inactive
@francinelucca francinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 2, 2026
Comment thread packages/react/src/ActionBar/ActionBar.tsx
Comment thread packages/react/src/ActionList/Group.tsx
@primer
Copy link
Copy Markdown
Contributor

primer Bot commented Apr 8, 2026

🤖 Lint issues have been automatically fixed and committed to this PR.

@francinelucca francinelucca changed the title feat(ActionBar): add data-component attributes for better accessibility feat: implement ADR-023 Part 1 Apr 8, 2026
@francinelucca francinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 22, 2026
@github-actions github-actions Bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 22, 2026
@github-actions github-actions Bot temporarily deployed to storybook-preview-7724 April 22, 2026 15:59 Inactive
@github-actions github-actions Bot temporarily deployed to storybook-preview-7724 April 22, 2026 16:09 Inactive
@github-actions github-actions Bot temporarily deployed to storybook-preview-7724 April 22, 2026 18:15 Inactive
francinelucca and others added 3 commits April 22, 2026 14:16
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions github-actions Bot requested a deployment to storybook-preview-7724 April 22, 2026 18:21 Abandoned
@primer-integration
Copy link
Copy Markdown

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/19160

@francinelucca
Copy link
Copy Markdown
Member Author

last run looks good, skipping IC manually since last update was just VRT

@primer primer Bot mentioned this pull request Apr 22, 2026
@primer-integration
Copy link
Copy Markdown

⚠️ Integration PR Outdated

This integration PR does not have the latest commit from the primer/react PR.

Integration PR references: a0b9c6004a119babc977761da0ed48afc7c81d38
Latest commit on primer/react PR: b8dc78b96a38e7f9890597f5a0cb4d0ee3edb232

Please update the integration PR to reference the latest commit from the primer/react PR before reviewing workflow results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Canary Release Apply this label when you want CI to create a canary release of the current PR integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: skipped manually Changes in this PR do not require an integration test staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants