Skip to content

chore: add ActionList primitives exports#7755

Merged
francinelucca merged 38 commits intomainfrom
chore/export-selection-primitive
Apr 29, 2026
Merged

chore: add ActionList primitives exports#7755
francinelucca merged 38 commits intomainfrom
chore/export-selection-primitive

Conversation

@francinelucca
Copy link
Copy Markdown
Member

@francinelucca francinelucca commented Apr 14, 2026

Exporting some primitives for https://github.com/github/primer/issues/6456

This pull request refactors and enhances the FilteredActionList and related components in the Primer React library. The main focus is on improving the modularity and extensibility of FilteredActionList by extracting the input field logic into its own component, updating exports for better accessibility, and adding new utility exports. There are also minor improvements to ActionList and SelectPanel, as well as updates to test snapshots and type exports.

New

  • Extracted the input logic from FilteredActionList into a new FilteredActionListInput component for better separation of concerns and reusability. The main component now uses this new input component.
  • Exposed the SelectPanelMessage component and added it as a property of SelectPanel for easier access.
  • Added or updated exports for additional types and utilities, including ActionListGroupHeadingProps, ActionListTrailingActionProps, and FocusKeys, to make them available for consumers of the package.
  • Updated the FilteredActionList export to include the new Input and BodyLoader subcomponents, and re-exported relevant types and loading constants for improved modularity.

Changed

  • Updated test snapshots to reflect the new and updated exports, ensuring test coverage stays in sync with the public API.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 14, 2026

🦋 Changeset detected

Latest commit: 30fe2c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

@francinelucca francinelucca added the Canary Release Apply this label when you want CI to create a canary release of the current PR label Apr 14, 2026
@github-actions github-actions Bot temporarily deployed to storybook-preview-7755 April 14, 2026 19:25 Inactive
@github-actions github-actions Bot requested a deployment to storybook-preview-7755 April 22, 2026 15:34 Abandoned
@github-actions github-actions Bot temporarily deployed to storybook-preview-7755 April 22, 2026 15:45 Inactive
@francinelucca francinelucca changed the title chore: add Selection type to ActionList exports chore: add ActionList primitives exports Apr 22, 2026
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 29, 2026

@copilot what is causing the react 19 tests to fail?

The React 19 failures are all in src/TreeView/TreeView.test.tsx — the rendered body is empty (<div />) when those tests run, so element queries like getByRole("treeitem") and getByRole("button") can't find anything. This is unrelated to our PR changes: the exact same TreeView failures appear on the main branch at the same point in time (e.g. CI run 25078575410 on main fails identically). It looks like a pre-existing flaky test issue in the TreeView test suite under the React 19 environment, not something introduced by the ActionList/SelectPanel/FilteredActionList exports work here.

@github-actions github-actions Bot requested a deployment to storybook-preview-7755 April 29, 2026 02:08 Abandoned
Removed unused exports from index.ts for cleaner code.
@github-actions github-actions Bot requested a deployment to storybook-preview-7755 April 29, 2026 02:13 Abandoned
@github-actions github-actions Bot requested a deployment to storybook-preview-7755 April 29, 2026 02:23 Abandoned
@github-actions github-actions Bot requested a deployment to storybook-preview-7755 April 29, 2026 02:29 Abandoned
@github-actions github-actions Bot temporarily deployed to storybook-preview-7755 April 29, 2026 02:38 Inactive
@primer-integration
Copy link
Copy Markdown

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/19663

@primer-integration
Copy link
Copy Markdown

Integration test results from github/github-ui:

Passed  CI   Passed
Passed  VRT   Passed
Passed  Projects   Passed

All checks passed!

@francinelucca francinelucca added this pull request to the merge queue Apr 29, 2026
Merged via the queue into main with commit 0e868f9 Apr 29, 2026
53 checks passed
@primer primer Bot mentioned this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Canary Release Apply this label when you want CI to create a canary release of the current PR integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants