Skip to content

Conversation

@smockle
Copy link
Member

@smockle smockle commented May 4, 2020

Defines SelectMenuItemProps as a discriminated union.

Follow-up testing: Does this mean the as prop is required? If so, can/should we default to either a or button?

@vercel
Copy link

vercel bot commented May 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/ob341hga1
✅ Preview: https://primer-components-git-selectmenuitem-ts.primer.now.sh

Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks @smockle! Nope, as is not required. If it's not set, the tag used in the styled components function is used (an anchor tag) :)

@emplums emplums merged commit 3eafee8 into SelectMenuItem May 4, 2020
@emplums emplums deleted the SelectMenuItem-ts branch May 4, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants