Deprecate Primer::ButtonComponent in favor of Primer::Beta::Button#1396
Merged
mxriverlynn merged 4 commits intomainfrom Sep 21, 2022
Merged
Deprecate Primer::ButtonComponent in favor of Primer::Beta::Button#1396mxriverlynn merged 4 commits intomainfrom
mxriverlynn merged 4 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 91500c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
mxriverlynn
added a commit
that referenced
this pull request
Sep 28, 2022
jonrohan
pushed a commit
that referenced
this pull request
Sep 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with the CI changes that have been made in the dotcom repo, we can safely deprecate components in PVC without requiring an all-or-nothing update in dotcom.
this PR marks the
Primer::ButtonComponentas deprecated in favor ofPrimer::Beta::Button. it also corrects the primer.style navigation so theButtonlink in the nav takes you to the beta button instead of the deprecated version.