Adding testing around writing previews#1507
Merged
Conversation
Co-authored-by: Katie Langerman <langermank@users.noreply.github.com>
🦋 Changeset detectedLatest commit: d987a99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonrohan
changed the title
langermank
reviewed
Oct 19, 2022
langermank
approved these changes
Oct 19, 2022
Contributor
langermank
left a comment
langermank
left a comment
There was a problem hiding this comment.
Just one silly comment 😆 this is great!
Co-authored-by: Katie Langerman <langermank@github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests to codify some of the adr requirements written up here https://github.com/github/primer/pull/1387.
The document says that every preview should have a
This PR does include some changes to the
static/arguments json file that add new attributes. For this part I'm including a changeset.Integration
No
Merge checklist