Tests to validate CSS used by components#1608
Merged
mxriverlynn merged 15 commits intomainfrom Nov 17, 2022
Merged
Conversation
… lots of challenges here
🦋 Changeset detectedLatest commit: 3087ae6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…rror for unmatched selectors
…component-css-use
… moved into PVC. also fixed when the assertion is made, so it catches all errors
Contributor
|
mxriverlynn
force-pushed
the
mxriverlynn/validate-component-css-use
branch
from
30d61ee to
ebe6567
Compare
jonrohan
reviewed
Nov 17, 2022
…ss-use' into mxriverlynn/validate-component-css-use
mxriverlynn
force-pushed
the
mxriverlynn/validate-component-css-use
branch
from
8030e99 to
3087ae6
Compare
jonrohan
approved these changes
Nov 17, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this PR adds CSS tests from the opposite direction of #1574, by looking for CSS classes that are used in PVC components and ensuring they are valid. to do that, it checks against the same css source as the previous PR, to find the classes in question.
Integration
no
Merge checklist