Skip to content

Conversation

@lesliecdubs
Copy link
Member

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

This PR makes the "status" fields in all ADRs consistent, as per https://github.com/github/primer/pull/5111/files (GitHub staff only)

Integration

No

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Modifies text to match preferred format

Anything you want to highlight for special attention from reviewers?

Check the diff for format consistency and typos

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@lesliecdubs lesliecdubs self-assigned this Apr 23, 2025
Copilot AI review requested due to automatic review settings April 23, 2025 01:32
@lesliecdubs lesliecdubs requested a review from a team as a code owner April 23, 2025 01:32
@lesliecdubs lesliecdubs requested a review from jonrohan April 23, 2025 01:32
@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2025

⚠️ No Changeset found

Latest commit: 0d027b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the format of the “status” fields in the ADR documents for consistency, following the referenced GitHub staff guidelines.

  • Modified the status section in multiple ADR files by replacing “Accepted and Adopted” with separate, formatted lines for "Status" and "Implementation."
  • Ensured consistent formatting across the ADR documentation.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
docs/adr/0252-build-component-css-with-ruby-code.md Reformatted status field to separate "Status" and "Implementation" lines.
docs/adr/0251-use-catalyst-for-client-side-behaviours.md Reformatted status field to separate "Status" and "Implementation" lines.
docs/adr/0250-developing-and-publishing-clientside-behaviours.md Reformatted status field to separate "Status" and "Implementation" lines.
docs/adr/0246-record-architecture-decisions.md Reformatted status field to separate "Status" and "Implementation" lines.

@lesliecdubs lesliecdubs added the skip changeset Pull requests that don't change the library output label Apr 23, 2025
@jonrohan jonrohan added this pull request to the merge queue Apr 24, 2025
Merged via the queue into main with commit f0aa6d2 Apr 24, 2025
30 checks passed
@jonrohan jonrohan deleted the lcw/updateAdrStatusFormat branch April 24, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Pull requests that don't change the library output

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants