Skip to content

Conversation

@primer
Copy link
Contributor

@primer primer bot commented May 6, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/view-components@0.43.2

Patch Changes

@primer primer bot requested a review from a team as a code owner May 6, 2025 18:53
@primer primer bot requested a review from TylerJDev May 6, 2025 18:53
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass
  • Lookbook opens in a browser
  • Successful integration test with GitHub.com as a primary consumer of Primer View Components
    • Install the npm release candidate: npm i -w ./npm-workspaces/primer/ @primer/view-components@next
    • Update primer_view_components gem: script/vendor-gem https://github.com/primer/view_components.git -r changeset-release/main
    • Verify no new build errors appear
    • Verify no new linting errors appear
    • Manually test critical paths
    • Manually test release-specific bugfixes and/or features work as described

🤔 Sanity test

  • All bugfixes in this release have resolved their corresponding issues
  • All new features in this release have been tested and verified as compatible with GitHub.com
  • No noticeable regressions have been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

🚢 Post ship reminders

  • Deploy lookbook via chat ops in the #primer-rails-ops channel. .deploy primer-lookbook to production

Please also leave any testing notes as a comment on this pull request. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to maintainers.

@primer primer bot requested review from jonrohan and removed request for TylerJDev May 6, 2025 18:54
@primer primer bot assigned jonrohan May 6, 2025
@primer primer bot force-pushed the changeset-release/main branch from 2d51568 to 871e50f Compare May 8, 2025 17:18
@primer primer bot force-pushed the changeset-release/main branch from 871e50f to 4808c33 Compare May 8, 2025 17:28
@HDinger
Copy link
Contributor

HDinger commented May 9, 2025

Hi Primer team,

I just wanted to share an insight that we spent quite some time on when trying to release our PVC fork. Currently, there are some issues with releasing, which will most likely affect you as well.
The changeset team has recently updated their release action in commit changesets/action@207dc3d . Basically they switched from

git push origin --tags

to

git push origin {{tagName}}

The first one just does nothing when there is no local tag while the second creates a failure and stops the execution. See for example our latest release run.

So we will either use an older version of changeset or update the changeset-publish script to create a local tag before trying to push it. I hope that this will help you and save some time.

@primer primer bot force-pushed the changeset-release/main branch from 4808c33 to b3974cd Compare May 9, 2025 20:21
@primer primer bot force-pushed the changeset-release/main branch from b3974cd to e1c93d8 Compare May 12, 2025 15:46
@primer primer bot removed the request for review from jonrohan May 12, 2025 15:46
@primer primer bot unassigned jonrohan May 12, 2025
@primer primer bot requested a review from hectahertz May 12, 2025 15:46
@primer primer bot force-pushed the changeset-release/main branch from e1c93d8 to 56085d8 Compare May 14, 2025 11:14
@primer primer bot force-pushed the changeset-release/main branch from 56085d8 to 7b3d427 Compare May 14, 2025 17:38
@primer primer bot force-pushed the changeset-release/main branch from 7b3d427 to 73b4bdb Compare May 14, 2025 17:45
@primer primer bot force-pushed the changeset-release/main branch from 73b4bdb to 4a70f88 Compare May 14, 2025 19:32
@primer primer bot force-pushed the changeset-release/main branch from 4a70f88 to a3f1848 Compare May 19, 2025 16:49
@primer primer bot unassigned hectahertz May 28, 2025
@primer primer bot requested review from jonrohan and removed request for hectahertz May 28, 2025 16:46
@primer primer bot force-pushed the changeset-release/main branch from d0951be to ec07a5b Compare May 30, 2025 14:11
@primer primer bot force-pushed the changeset-release/main branch from ec07a5b to d3d9c19 Compare June 2, 2025 12:13
@primer primer bot force-pushed the changeset-release/main branch from d3d9c19 to cf3b35c Compare June 2, 2025 17:48
@primer primer bot force-pushed the changeset-release/main branch from cf3b35c to f398431 Compare June 2, 2025 17:56
@primer primer bot force-pushed the changeset-release/main branch from f398431 to e2d62f1 Compare June 2, 2025 17:56
@primer primer bot force-pushed the changeset-release/main branch from e2d62f1 to bbbe1cf Compare June 2, 2025 18:03
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025

⚠️ Visual or ARIA snapshot differences found

Our visual and ARIA snapshot tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review differences

@github-actions github-actions bot requested a review from a team as a code owner June 2, 2025 18:15
@github-actions github-actions bot requested a review from alliethu June 2, 2025 18:15
@primer primer bot force-pushed the changeset-release/main branch from 83c24be to c7ea96f Compare June 2, 2025 18:28
@primer primer bot force-pushed the changeset-release/main branch from 45dc3c3 to 074c6c0 Compare June 3, 2025 00:34
@jonrohan jonrohan enabled auto-merge June 3, 2025 20:21
@jonrohan jonrohan added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit 3f8aab1 Jun 3, 2025
29 of 30 checks passed
@jonrohan jonrohan deleted the changeset-release/main branch June 3, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants