Conversation
🦋 Changeset detectedLatest commit: afa5797 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Dialog component to make the large heading size the same as the default size, effectively removing the visual distinction of the large variant while maintaining API compatibility.
Key changes:
- Standardized dialog title font sizes to use small title shorthand across different dialog variants
- Improved CSS selector formatting for better readability
- Added explanatory comment about the non-breaking nature of this change
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| initial-value: 0; | ||
| inherits: false; | ||
| syntax: "<length>"; | ||
| syntax: '<length>'; |
There was a problem hiding this comment.
CSS property syntax values should use double quotes instead of single quotes for consistency with the CSS specification and better tooling support.
| syntax: '<length>'; | |
| syntax: "<length>"; |
|
This reverts commit 3c4bedb.
Part of https://github.com/github/primer/issues/4257
Closes https://github.com/github/primer/issues/5952
Basically removing the
largevariant but just visually so this isn't a proper major..