feat: health check #278
Merged
feat: health check #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrekucci
reviewed
Jul 29, 2024
Mikelle
approved these changes
Jul 29, 2024
mrekucci
reviewed
Jul 29, 2024
Contributor
mrekucci
left a comment
mrekucci
left a comment
There was a problem hiding this comment.
The health check should also be used across infra Nomad scripts.
added 10 commits
July 30, 2024 12:12
added 2 commits
July 30, 2024 12:47
mrekucci
reviewed
Jul 30, 2024
infrastructure/nomad/playbooks/templates/jobs/mev-commit-oracle.nomad.j2
Outdated
Show resolved
Hide resolved
added 2 commits
July 30, 2024 13:28
mrekucci
reviewed
Jul 30, 2024
|
|
||
| srv := apiserver.New(opts.Version, opts.Logger.With("component", "apiserver")) | ||
| peerType := p2p.FromString(opts.PeerType) | ||
| healthChecker := health.New() |
Contributor
There was a problem hiding this comment.
nit: this can be defined closer to it's first usage on the line 547.
| "google.golang.org/grpc/connectivity" | ||
| ) | ||
|
|
||
| type HealthCheck interface { |
Contributor
There was a problem hiding this comment.
HealthCheck -> HealthChecker
| }) | ||
| } | ||
|
|
||
| func New() Health { |
Contributor
There was a problem hiding this comment.
This constructor is not necessary, I'd suggest to export the health struct below and use new(Health) instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add proper health check for mev-commit and oracle.
Issue ticket number and link
#277
Checklist before requesting a review