-
Notifications
You must be signed in to change notification settings - Fork 20
feat: introduces additive slashing penalty #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaspitz
reviewed
Aug 1, 2024
Contributor
shaspitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid, there are some remaining failing tests
shaspitz
reviewed
Aug 7, 2024
0fc54c1 to
36c4ce4
Compare
shaspitz
reviewed
Aug 7, 2024
shaspitz
approved these changes
Aug 7, 2024
* feat: logs details of preconf in logs * feat: stops sending bid rejection over node * chore: leave bid reject for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Historically, the slashing penalty for a provider was the total amount of a bid that would be accrued, from which a portion goes to the bidder and a portion goes to the treasury. However, this leads to negative UX for the bidder, who should be compensated in full for a provider's rebuttal of a pre-confirmation. This PR introduces an additive penalty to the provider, such that a 105% of the decayed bid amount is slashed from the provider stake. This is to support sending a 100% of the decayed bid to the bidder, and 5% to the treasury. Note: We are also increasing the funds sent to the treasury from 2% to 5% for the slashing case.
Checklist before requesting a review