Skip to content

Conversation

@ckartik
Copy link
Contributor

@ckartik ckartik commented Aug 1, 2024

Describe your changes

Historically, the slashing penalty for a provider was the total amount of a bid that would be accrued, from which a portion goes to the bidder and a portion goes to the treasury. However, this leads to negative UX for the bidder, who should be compensated in full for a provider's rebuttal of a pre-confirmation. This PR introduces an additive penalty to the provider, such that a 105% of the decayed bid amount is slashed from the provider stake. This is to support sending a 100% of the decayed bid to the bidder, and 5% to the treasury. Note: We are also increasing the funds sent to the treasury from 2% to 5% for the slashing case.

Checklist before requesting a review

  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation

@ckartik ckartik requested a review from shaspitz August 1, 2024 16:14
Copy link
Contributor

@shaspitz shaspitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, there are some remaining failing tests

@ckartik ckartik requested a review from shaspitz August 7, 2024 00:23
@ckartik ckartik force-pushed the ckartik/update-slashing-mechanism branch from 0fc54c1 to 36c4ce4 Compare August 7, 2024 00:51
@ckartik ckartik requested a review from shaspitz August 7, 2024 01:41
@ckartik ckartik requested a review from shaspitz August 7, 2024 01:57
ckartik added 3 commits August 6, 2024 22:14
* feat: logs details of preconf in logs

* feat: stops sending bid rejection over node

* chore: leave bid reject for now
@ckartik ckartik changed the title Introduces Additive Penalty for Slashing feat: Introduces Additive Penalty for Slashing Aug 7, 2024
@ckartik ckartik changed the title feat: Introduces Additive Penalty for Slashing feat: introduces additive slashing penalty Aug 7, 2024
@ckartik ckartik merged commit c78997d into main Aug 7, 2024
@ckartik ckartik deleted the ckartik/update-slashing-mechanism branch August 7, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants