feat: add validator api #310
Conversation
shaspitz
left a comment
shaspitz
left a comment
There was a problem hiding this comment.
Did querying the router contract end up working? ie. this is working e2e?
| Name: "validator-router-contract", | ||
| Usage: "address of the validator router contract", | ||
| EnvVars: []string{"MEV_COMMIT_VALIDATOR_ROUTER_ADDR"}, | ||
| Action: func(ctx *cli.Context, s string) error { |
There was a problem hiding this comment.
Should we supply a default value for deployment on Holesky? If it exists
There was a problem hiding this comment.
We don't do it for oracle, so I didn't add default variable here (as it also comes with private key for the alchemy)
| $ref: '#/definitions/googlerpcStatus' | ||
| /v1/validator/get_validators: | ||
| get: | ||
| summary: GetValidators |
There was a problem hiding this comment.
Is there a reason why we separate this out from GetEpoch? Ie. why not just have a single endpoint that returns the validators of the latest epoch?
Reasoning here should prob be in our docs
There was a problem hiding this comment.
Asked Evan, he said that it's sufficient for GetEpoch be done automatically in GetValidators request
|
We'll want to add some docs on how bidders can utilize these new endpoints to have better UX, along with any timing considerations |
|
Thank you for the review! I definitely agree on the necessity of documentation. I wanted to add it once we have the latest smart contract set and that branch finalized and merged. |
Router is working with fake ValidatorRegistry (which is always returns true) |
Describe your changes
Add validator API
Issue ticket number and link
Fixes #309
Checklist before requesting a review