feat: use abigen code for contracts and add debug service #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aloknerurkar
commented
May 20, 2024
aloknerurkar
commented
- We added a new library for the oracle to cleanly use the abigen code for making contract calls/transactions. This change will make use of the same library in p2p to use the abigen code. This will reduce a lot of unnecessary code and be less error prone. Also this provides safer sequential transaction processing from the nodes.
- Added a new gRPC service called debug to house common debugging APIs. Previously the transaction related helper APIs were only available on provider node. Now the bidder node also could make transactions. These debugging APIs will be needed again. So having a common service makes more sense. This will also include the topology API so it can be documented and versioned. This can also be useful to try out experimental APIs.
- Oracle allows limited parallel settlements to prioritize the record winner transaction.
mrekucci
reviewed
May 21, 2024
Mikelle
reviewed
May 21, 2024
* feat: add forge clean * feat: removes redundant build
* refactor: keykeeper refactoring (#68) * refactor: moved aes to the store, moved crypto functions to crypto package * refactor: deleted nike from keykeeper * chore: fixes after merge * refactor: moved ecies out of keykeeper * refactor: moved nike keys out of keykeeper * refactor: get rid of keykeeper * refactor: updated oracle to move to x/keysigner * chore: fixed lint * fix: fixed some pr comments * chore: fixed pr comments * chore: moved aeskey out * chore: added tests for the keys in the store
* fix: updated entrypoint * fix: add gas price for the funder * fix: gas price
* chore: sending pre-conf before saving to sc * fix: fixed empty window number in response
added 8 commits
May 22, 2024 17:27
Mikelle
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.