Skip to content

chore: encryptor optimizations #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mikelle merged 8 commits into from
May 28, 2024
Merged

chore: encryptor optimizations #83

Mikelle merged 8 commits into from
May 28, 2024

Conversation

@Mikelle
Copy link
Contributor

@Mikelle Mikelle commented May 22, 2024 •
edited
Loading

  • changed json marshalling to proto
  • Set up keys for encryptor once, instead of getting it from the store every time
  • Added new errors for the code cleanliness

@Mikelle Mikelle requested a review from aloknerurkar May 22, 2024 14:58
aloknerurkar
aloknerurkar reviewed May 23, 2024
View reviewed changes
@Mikelle Mikelle requested a review from aloknerurkar May 23, 2024 17:49
aloknerurkar
aloknerurkar reviewed May 23, 2024
View reviewed changes
@Mikelle Mikelle requested review from aloknerurkar and removed request for aloknerurkar May 23, 2024 18:37
@Mikelle Mikelle force-pushed the encryptor-optimizations branch 2 times, most recently from 82ebd52 to 5f228a5 Compare May 27, 2024 21:12
aloknerurkar
aloknerurkar reviewed May 28, 2024
View reviewed changes
@Mikelle Mikelle force-pushed the encryptor-optimizations branch from 207b360 to e1c72ed Compare May 28, 2024 11:04
@Mikelle Mikelle requested a review from aloknerurkar May 28, 2024 11:31
@Mikelle Mikelle merged commit 936c828 into main May 28, 2024
@Mikelle Mikelle deleted the encryptor-optimizations branch May 28, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aloknerurkar aloknerurkar aloknerurkar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mikelle @aloknerurkar