feat(openai): yield thinking chunks #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'd prefer to be explicit about what keys are used, at least for now |
Contributor
Author
|
Sure thing! Did it because I (stupidly) didn't realize this was the case and thought my org still wasn't verified 🙃 |
sixlive
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finally got around to verify my org. This adds streaming for thinking chunks.
Also, this merges providerOptions into the request instead of only taking a few keys from it.
Breaking Changes
Might be breaking in the sense that if people don't check for the chunk type, they will now render thinking chunks.Can't happen, as no one can use streaming yet.As i now merge providerOptions into the request, invalid options might lead to failing requests (before, onlyprevious_response_id&truncationwere passed.