fix: laravel mcp structured usage #863
Merged
+134
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview deployments for prism ⚡️
Commit: Deployment ID: Static site name: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #788
When a Laravel MCP tool returns
Response::structured()orResponse::make(), Prism throws an error because these methods return aResponseFactoryinstead of aResponse. TheResponseFactoryclass is neither iterable nor has acontent()method, causing the code to fail.This PR adds explicit handling for
ResponseFactoryinLaravelMcpTool::__invoke()by extracting the responses from the factory and converting them to strings.Changes
ResponseFactoryimport and type annotation inLaravelMcpToolResponseFactoryresponses by callingresponses()and mapping content to stringslaravel/mcpdependency to^0.5.2