Skip to content

fix: remove custom PostHog telemetry timeouts#26

Merged
AmanVarshney01 merged 1 commit intomainfrom
aman/remove-telemetry-timeouts
Mar 17, 2026
Merged

fix: remove custom PostHog telemetry timeouts#26
AmanVarshney01 merged 1 commit intomainfrom
aman/remove-telemetry-timeouts

Conversation

@AmanVarshney01
Copy link
Member

@AmanVarshney01 AmanVarshney01 commented Mar 17, 2026

Summary

  • remove the custom PostHog request timeout override from CLI telemetry
  • stop passing a custom shutdown timeout and use the SDK default instead
  • keep the immediate flush behavior for the short-lived CLI flow

Why

The 800ms custom timeout was causing telemetry requests from the CLI to abort before PostHog finished sending them.

Testing

  • bun run build
  • bun run check
  • bun run typecheck
  • smoke run: node dist/cli.mjs --yes --name smoke-app --template hono --provider sqlite --package-manager npm --no-install --no-generate --schema-preset basic

Summary by CodeRabbit

  • Chores
    • Simplified internal telemetry configuration and shutdown handling.

@github-actions
Copy link

PR preview published

  • Version: 0.3.0-pr.26.38.1
  • Tag: pr26
  • Run with Bun: bunx create-prisma@pr26
  • Run with npm: npx create-prisma@pr26
  • Run with Yarn: yarn dlx create-prisma@pr26
  • Run with pnpm: pnpm dlx create-prisma@pr26
  • Run with Deno: deno run -A npm:create-prisma@pr26
  • Workflow run: https://github.com/prisma/create-prisma/actions/runs/23200439062

@AmanVarshney01 AmanVarshney01 changed the title Remove custom PostHog telemetry timeouts fix: remove custom PostHog telemetry timeouts Mar 17, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

Walkthrough

Removed hardcoded telemetry timing constants TELEMETRY_REQUEST_TIMEOUT_MS and TELEMETRY_SHUTDOWN_TIMEOUT_MS from the telemetry client. Simplified PostHog client initialization and shutdown by eliminating explicit timeout configurations.

Changes

Cohort / File(s) Summary
Telemetry Client
src/telemetry/client.ts
Removed two hardcoded timing constants and their usages. Simplified PostHog client initialization by omitting requestTimeout option and shutdown behavior by removing explicit timeout parameter.
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing custom PostHog telemetry timeouts from the CLI configuration.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch aman/remove-telemetry-timeouts
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e805fb41-313f-4158-84bd-61f11874c3b1

📥 Commits

Reviewing files that changed from the base of the PR and between 83ad690 and 62b3eb7.

📒 Files selected for processing (1)
  • src/telemetry/client.ts

@AmanVarshney01 AmanVarshney01 merged commit 65f3d5d into main Mar 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants