Skip to content

Conversation

@keerlu
Copy link
Contributor

@keerlu keerlu commented Mar 3, 2022

Update with latest output from error_code_parser.py script

This seems to delete text from some errors (e.g. P1003, P1012) so probably needs tweaking a bit

Describe this PR

Changes

What issue does this fix?

Any other relevant information

Update with latest output from error_code_parser.py script
@netlify
Copy link

netlify bot commented Mar 3, 2022

✔️ Deploy Preview for prisma2-docs ready!

🔨 Explore the source changes: 7ece81f

🔍 Inspect the deploy log: https://app.netlify.com/sites/prisma2-docs/deploys/62274a5e2478d8000768788d

😎 Browse the preview: https://deploy-preview-2938--prisma2-docs.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

This PR changes the following pages (Netlify Preview Deploy links):

(Note that links will only be valid after Netlify preview deploy succeeded)

Comment on lines +139 to +145
#### <inlinecode>P1018</inlinecode>

"{message}"

#### <inlinecode>P1019</inlinecode>

"{message}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script might not be capable of getting actual message here, or it is so variable as P1012 that it would make sense to get the actual, additional error codes either manually or adapting the script.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where to get the errors from. Looking at the script, for P1012 it gets the list of messages from here (the updated path for the url5 link that returns a 404). But it's not obvious to me why these were used for P1012, or where I'd get the corresponding list for P1018 and P1019.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The engine code is not necessarily written to make it easy to parse this way, so Martina (who built this script) probably just asked and then added a special case for that file where it made sense - possibly the file that @garrensmith linked to might be the correct one to use here (or manually of course).

Side note: Adding to the file which section was auto generated and which one edited manually might be useful for the future.

Manually tweak generated errors
@keerlu
Copy link
Contributor Author

keerlu commented Dec 2, 2022

This is very old now, will be better to open a new PR next time we regenerate the error reference

@keerlu keerlu closed this Dec 2, 2022
@janpio janpio deleted the regenerate-error-codes branch November 15, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants