-
Notifications
You must be signed in to change notification settings - Fork 863
Regenerate errors in Error Reference page #2938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update with latest output from error_code_parser.py script
|
✔️ Deploy Preview for prisma2-docs ready! 🔨 Explore the source changes: 7ece81f 🔍 Inspect the deploy log: https://app.netlify.com/sites/prisma2-docs/deploys/62274a5e2478d8000768788d 😎 Browse the preview: https://deploy-preview-2938--prisma2-docs.netlify.app |
|
This PR changes the following pages (Netlify Preview Deploy links): (Note that links will only be valid after Netlify preview deploy succeeded) |
| #### <inlinecode>P1018</inlinecode> | ||
|
|
||
| "{message}" | ||
|
|
||
| #### <inlinecode>P1019</inlinecode> | ||
|
|
||
| "{message}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script might not be capable of getting actual message here, or it is so variable as P1012 that it would make sense to get the actual, additional error codes either manually or adapting the script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure where to get the errors from. Looking at the script, for P1012 it gets the list of messages from here (the updated path for the url5 link that returns a 404). But it's not obvious to me why these were used for P1012, or where I'd get the corresponding list for P1018 and P1019.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the errors are in these files https://github.com/prisma/prisma-engines/tree/main/libs/user-facing-errors/src
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The engine code is not necessarily written to make it easy to parse this way, so Martina (who built this script) probably just asked and then added a special case for that file where it made sense - possibly the file that @garrensmith linked to might be the correct one to use here (or manually of course).
Side note: Adding to the file which section was auto generated and which one edited manually might be useful for the future.
content/400-reference/200-api-reference/250-error-reference.mdx
Outdated
Show resolved
Hide resolved
content/400-reference/200-api-reference/250-error-reference.mdx
Outdated
Show resolved
Hide resolved
content/400-reference/200-api-reference/250-error-reference.mdx
Outdated
Show resolved
Hide resolved
content/400-reference/200-api-reference/250-error-reference.mdx
Outdated
Show resolved
Hide resolved
content/400-reference/200-api-reference/250-error-reference.mdx
Outdated
Show resolved
Hide resolved
content/400-reference/200-api-reference/250-error-reference.mdx
Outdated
Show resolved
Hide resolved
content/400-reference/200-api-reference/250-error-reference.mdx
Outdated
Show resolved
Hide resolved
Manually tweak generated errors
|
This is very old now, will be better to open a new PR next time we regenerate the error reference |
Update with latest output from error_code_parser.py script
This seems to delete text from some errors (e.g. P1003, P1012) so probably needs tweaking a bit
Describe this PR
Changes
What issue does this fix?
Any other relevant information