-
Notifications
You must be signed in to change notification settings - Fork 855
DC-5041 Datasource URLs Deprecated #7226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDocumentation updates across three files add deprecation notices for datasource block fields (url, directUrl, shadowDatabaseUrl) in Prisma ORM v7, directing users to configure these via Prisma Config instead of the Prisma schema. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Pre-merge checks✅ Passed checks (2 passed)
Comment |
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
Deploying docs with
|
| Latest commit: |
ea9291b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a94c0346.docs-51g.pages.dev |
| Branch Preview URL: | https://dc-5041-datasource-url-depre.docs-51g.pages.dev |
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
content/200-orm/500-reference/325-prisma-config-reference.mdx (1)
104-104: Minor: Comment inconsistency with field name casing.Line 104 references
directURL(capital "URL"), but the actual field defined on line 108 isdirectUrl(lowercase "url"). While this is a pre-existing comment in the type definition (not part of the deprecation changes), consider aligning the comment to match the actual camelCase field naming convention.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
content/200-orm/100-prisma-schema/10-overview/02-data-sources.mdx(1 hunks)content/200-orm/500-reference/100-prisma-schema-reference.mdx(1 hunks)content/200-orm/500-reference/325-prisma-config-reference.mdx(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-10-08T16:23:00.388Z
Learnt from: aidankmcalister
Repo: prisma/docs PR: 7165
File: content/800-guides/550-test-guide.mdx:85-90
Timestamp: 2025-10-08T16:23:00.388Z
Learning: For .mdx files in the prisma/docs repository: Only flag code snippets for (1) exposed secrets with real-looking values that should be placeholders (e.g., API keys, database passwords, AWS credentials), or (2) blatant syntax errors like missing parentheses, brackets, braces, or mismatched delimiters. Do not flag code quality issues, anti-patterns, security vulnerabilities, missing error handling, unused variables, or any other bad practices, as documentation intentionally shows problematic code.
Applied to files:
content/200-orm/500-reference/325-prisma-config-reference.mdx
📚 Learning: 2025-10-09T21:32:50.340Z
Learnt from: aidankmcalister
Repo: prisma/docs PR: 7167
File: content/900-ai/prompts/astro.mdx:84-84
Timestamp: 2025-10-09T21:32:50.340Z
Learning: The `npx prisma init` command supports the following flags: `--db` (shorthand for `--datasource-provider prisma+postgres`), `--output` (specifies output location for generated client), `--generator-provider` (defines the generator provider), `--datasource-provider`, `--url`, `--preview-feature`, and `--with-model`. These are documented valid CLI options for Prisma init command.
Applied to files:
content/200-orm/500-reference/325-prisma-config-reference.mdxcontent/200-orm/100-prisma-schema/10-overview/02-data-sources.mdxcontent/200-orm/500-reference/100-prisma-schema-reference.mdx
🔇 Additional comments (4)
content/200-orm/100-prisma-schema/10-overview/02-data-sources.mdx (1)
9-11: Deprecation notice placement and clarity look good.The note block is positioned appropriately before the datasource example, ensuring readers encounter the deprecation warning early. The message is clear and actionable, directing users to configure these fields in Prisma Config.
content/200-orm/500-reference/325-prisma-config-reference.mdx (1)
377-379: Deprecation replacement notes are well-structured and consistent.The inline notes clearly communicate what each Prisma Config datasource field replaces from the schema block. The placement immediately after each property description makes the relationship obvious to readers. The messaging is consistent across all three replacements, and the version indicator (v7 and later) is helpful.
Also applies to: 390-392, 403-405
content/200-orm/500-reference/100-prisma-schema-reference.mdx (2)
21-23: Table deprecation notices provide clear migration path.The updated table entries effectively communicate the deprecation for each field (url, shadowDatabaseUrl, directUrl) with specific guidance on which Prisma Config field to use as a replacement. The embedded links to the corresponding config reference sections are helpful and appropriately scoped.
27-29: Note block complements table entries with emphasis.The additional note block reinforces the deprecation message from a higher level, providing readers with a clear summary before diving into individual field details. While somewhat redundant with the table entries, it serves as a useful callout for users skimming the documentation.
Summary by CodeRabbit
url,directUrl,shadowDatabaseUrl) as of Prisma ORM v7