-
Notifications
You must be signed in to change notification settings - Fork 855
DC-6174: Remove adapter, engine, directUrl, studio from config #7256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying docs with
|
| Latest commit: |
273f3fb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7400eb1d.docs-51g.pages.dev |
| Branch Preview URL: | https://prisma-7-adapter.docs-51g.pages.dev |
WalkthroughDocumentation changes to reflect Prisma v7 config: move datasource URL and env loading into Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🧰 Additional context used🧠 Learnings (4)📚 Learning: 2025-10-08T16:22:57.129ZApplied to files:
📚 Learning: 2025-10-08T16:23:00.388ZApplied to files:
📚 Learning: 2025-10-08T16:23:00.388ZApplied to files:
📚 Learning: 2025-10-14T11:41:08.844ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (3)
Comment |
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
🍈 Lychee Link Check Report
📊 Results Overview
|
🍈 Lychee Link Check Report
📊 Results Overview
|
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 200-orm/800-more/300-upgrade-guides/800-upgrade-from-prisma-1/06-upgrading-prisma-binding-to-sdl-first.mdx
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
content/200-orm/500-reference/325-prisma-config-reference.mdx (2)
632-638: Inconsistent path style in multi-file schemas example.The example at line 637 uses
path.join("prisma", "schema")while all other v7 examples use string literals (e.g.,'prisma/schema.prisma'). For consistency with the documented v7 convention, consider updating this to:schema: 'prisma/schema'Alternatively, if
path.joinis deliberately shown for educational purposes, adding a comment explaining when each style is preferred would clarify.
641-653: Clarify multi-file schema guidance for v7 datasource relocation.The explanation at line 641 states that migrations must be "located next to the
.prismafile that defines thedatasourceblock." In v7, the datasource is defined inprisma.config.ts, not in schema files. Consider adding a brief clarification:In that case, your `migrations` directory must be located next to the primary `.prisma` file (the one referenced in prisma.config.ts's `schema` setting). The datasource is now configured in `prisma.config.ts`, not in the schema file.This prevents users from searching for a datasource block in their schema files.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
content/200-orm/500-reference/100-prisma-schema-reference.mdx(1 hunks)content/200-orm/500-reference/325-prisma-config-reference.mdx(11 hunks)
✅ Files skipped from review due to trivial changes (1)
- content/200-orm/500-reference/100-prisma-schema-reference.mdx
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-08-11T09:40:55.237Z
Learnt from: ankur-arch
Repo: prisma/docs PR: 7066
File: content/200-orm/200-prisma-client/700-debugging-and-troubleshooting/245-troubleshooting-binary-size-issues.mdx:8-22
Timestamp: 2025-08-11T09:40:55.237Z
Learning: When the queryCompiler preview feature is enabled in Prisma ORM (v6.7.0+), it does not require Rust engines for CLI tools like `prisma migrate` or `prisma db pull`. The previous understanding that CLI tools would still need Rust binaries even with queryCompiler enabled is incorrect.
Applied to files:
content/200-orm/500-reference/325-prisma-config-reference.mdx
📚 Learning: 2025-10-09T21:32:50.340Z
Learnt from: aidankmcalister
Repo: prisma/docs PR: 7167
File: content/900-ai/prompts/astro.mdx:84-84
Timestamp: 2025-10-09T21:32:50.340Z
Learning: The `npx prisma init` command supports the following flags: `--db` (shorthand for `--datasource-provider prisma+postgres`), `--output` (specifies output location for generated client), `--generator-provider` (defines the generator provider), `--datasource-provider`, `--url`, `--preview-feature`, and `--with-model`. These are documented valid CLI options for Prisma init command.
Applied to files:
content/200-orm/500-reference/325-prisma-config-reference.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: runner / linkspector
- GitHub Check: Check internal links
- GitHub Check: Cloudflare Pages
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 200-orm/800-more/600-help-and-troubleshooting/050-dataguide/02-introduction-to-data-types.mdx
Errors in 200-orm/800-more/600-help-and-troubleshooting/800-check-constraints.mdx
Errors in 250-postgres/300-database/525-postgres-extensions.mdx
|
Summary by CodeRabbit