feat(skills): added baseline for skills cluster#49
Merged
Conversation
|
Warning Review limit reached
More reviews will be available in 49 minutes and 28 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (16)
WalkthroughThis PR introduces a complete agent skills framework for Prisma CLI, enabling LLM-based agents to guide users through Prisma Compute deployments. It includes validation tooling for skill definitions, multiple skills for routing and deployment guidance, CLI help text integration, and manual journey tests to validate agent behavior. ChangesAgent Skills Framework
🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
luanvdw
force-pushed
the
feat/skills-integration
branch
from
03f56c8 to
67cc581
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/cli/src/shell/command-meta.ts`:
- Line 149: The command string "pnpm dlx skills@latest add
prisma/prisma-cli/skills#cli-v<version> --all" uses the inconsistent placeholder
<version>; update that literal to use the <cli-version> placeholder so it
matches other docs (use "pnpm dlx skills@latest add
prisma/prisma-cli/skills#cli-v<cli-version> --all" wherever that string
appears).
In `@packages/cli/tests/app.test.ts`:
- Line 152: The test assertion in packages/cli/tests/app.test.ts is still
expecting the example string with the old "<version>" placeholder; update the
expect on deployHelp.stderr to use "<cli-version>" to match the changed
placeholder in command-meta.ts (and ensure the test string exactly matches the
example output produced by the code that reads command-meta.ts).
In `@scripts/validate-skills.mjs`:
- Around line 134-147: validateSkillFile currently calls readFileSync and will
throw if a CLI-supplied file is missing/unreadable; update validateSkillFile to
wrap the readFileSync call in a try/catch and return a structured offence object
instead of throwing so runCheck can continue validating other files.
Specifically, in validateSkillFile catch errors from readFileSync and return {
file: relative(root, filePath), errors: [ `Unable to read file: ${err.message}`
] } (or a similar single-item errors array) so runCheck's
files.map(...).filter(...) still works and missing/unreadable files are reported
rather than aborting the whole process.
In `@scripts/validate-skills.test.mjs`:
- Line 83: The assertion in the test comparing offences[0].file to the hardcoded
"skills/bad-skill/SKILL.md" is OS-dependent and should be made
platform-agnostic: import or require Node's path and replace the literal
expected string with a normalized or joined path (e.g., build expected with
path.join("skills", "bad-skill", "SKILL.md") or compare
path.normalize(offences[0].file) to path.normalize(expected)), ensuring you
reference offences[0].file and the test assertion (strictEqual) so the
comparison works correctly on Windows and POSIX environments.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 62890be1-ea91-47e9-9df9-f983a2b3524e
📒 Files selected for processing (16)
.gitignoreREADME.mdpackage.jsonpackages/cli/README.mdpackages/cli/src/shell/command-meta.tspackages/cli/tests/app.test.tsscripts/validate-skills.mjsscripts/validate-skills.test.mjsskills/DEVELOPING.mdskills/README.mdskills/journey-tests/01-nextjs-first-deploy.mdskills/journey-tests/02-feedback-bug.mdskills/journey-tests/README.mdskills/prisma-cli-deploy-nextjs/SKILL.mdskills/prisma-cli-feedback/SKILL.mdskills/prisma-cli/SKILL.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a baseline Prisma CLI skills cluster for agent-guided Next.js deploys, drawing inspiration from the Prisma Next skills integration. Includes install/discovery docs, validation scripts, focused journey tests, and a CLI help breadcrumb so agents can find the workflow.