Conversation
… package.json with real dependencies
jkomyno
added a commit
that referenced
this pull request
Feb 25, 2026
… actions Address wmadden's PR #168 review feedback (blocking issue #2): - Add DDL generation test: verifies the planner outputs ON DELETE CASCADE and ON UPDATE RESTRICT clauses when planning from a contract with referential actions against an empty database. - Add runtime behavior tests for all five ON DELETE actions: CASCADE (removes children), RESTRICT (blocks delete), SET NULL (nullifies FK), SET DEFAULT (applies default), NO ACTION (blocks). - Add ON UPDATE CASCADE test: propagates PK changes to children. These tests close the spec-mandated E2E coverage gap for the referential action matrix (spec lines 158-203, acceptance criteria #5-#6).
wmadden
added a commit
that referenced
this pull request
Mar 30, 2026
…arget Polymorphism is a cross-family concern — SQL needs single-table inheritance and enum-discriminated rows, MongoDB needs polymorphic collections, embedded fields, and mixed-type arrays. Both require discriminated unions in the contract type system. Rewrites design question #6 to cover both families with concrete storage mapping patterns and defines minimum April validation scope: contract can express discriminated unions, emitter produces narrowed TS types, ORM queries return narrowed types, STI storage mapping works for both families.
wmadden
added a commit
that referenced
this pull request
Mar 30, 2026
Promote design principles (self-describing domain model, domain/persistence separation, scoped family details, facts-not-instructions) to cross-cutting learnings. Update contract-symmetry with domain/storage separation proposal. Update design questions #1 (embedding as relation property), #6 (discriminator + variants), #10 (domain level as shared contract surface) with concrete design answers. Update overview with redesign summary.
wmadden
added a commit
that referenced
this pull request
Mar 30, 2026
wmadden
added a commit
that referenced
this pull request
Mar 30, 2026
Phase 3 (minimal Mongo ORM) proved the contract shape. Comparative analysis with the SQL ORM revealed the Collection chaining API, CollectionState, and row type inference are shared architectural patterns. Record this finding: - ADR 4: shared Collection interface with fluent chaining, family- specific compilation at terminal methods, spike-then-extract approach - Cross-cutting learning #6: shared ORM surface enumeration - Mongo Overview: Phase 3 complete, DQ #7 resolved, ADR 4 referenced - PoC plan: Phase 3 moved to completed, Phase 4 rewritten for Collection interface direction
wmadden
added a commit
that referenced
this pull request
Mar 30, 2026
…arget Polymorphism is a cross-family concern — SQL needs single-table inheritance and enum-discriminated rows, MongoDB needs polymorphic collections, embedded fields, and mixed-type arrays. Both require discriminated unions in the contract type system. Rewrites design question #6 to cover both families with concrete storage mapping patterns and defines minimum April validation scope: contract can express discriminated unions, emitter produces narrowed TS types, ORM queries return narrowed types, STI storage mapping works for both families.
wmadden
added a commit
that referenced
this pull request
Mar 30, 2026
Promote design principles (self-describing domain model, domain/persistence separation, scoped family details, facts-not-instructions) to cross-cutting learnings. Update contract-symmetry with domain/storage separation proposal. Update design questions #1 (embedding as relation property), #6 (discriminator + variants), #10 (domain level as shared contract surface) with concrete design answers. Update overview with redesign summary.
wmadden
added a commit
that referenced
this pull request
Mar 30, 2026
wmadden
added a commit
that referenced
this pull request
Mar 30, 2026
Phase 3 (minimal Mongo ORM) proved the contract shape. Comparative analysis with the SQL ORM revealed the Collection chaining API, CollectionState, and row type inference are shared architectural patterns. Record this finding: - ADR 4: shared Collection interface with fluent chaining, family- specific compilation at terminal methods, spike-then-extract approach - Cross-cutting learning #6: shared ORM surface enumeration - Mongo Overview: Phase 3 complete, DQ #7 resolved, ADR 4 referenced - PoC plan: Phase 3 moved to completed, Phase 4 rewritten for Collection interface direction
wmadden
added a commit
that referenced
this pull request
Mar 31, 2026
…arget Polymorphism is a cross-family concern — SQL needs single-table inheritance and enum-discriminated rows, MongoDB needs polymorphic collections, embedded fields, and mixed-type arrays. Both require discriminated unions in the contract type system. Rewrites design question #6 to cover both families with concrete storage mapping patterns and defines minimum April validation scope: contract can express discriminated unions, emitter produces narrowed TS types, ORM queries return narrowed types, STI storage mapping works for both families.
wmadden
added a commit
that referenced
this pull request
Mar 31, 2026
Promote design principles (self-describing domain model, domain/persistence separation, scoped family details, facts-not-instructions) to cross-cutting learnings. Update contract-symmetry with domain/storage separation proposal. Update design questions #1 (embedding as relation property), #6 (discriminator + variants), #10 (domain level as shared contract surface) with concrete design answers. Update overview with redesign summary.
wmadden
added a commit
that referenced
this pull request
Mar 31, 2026
wmadden
added a commit
that referenced
this pull request
Mar 31, 2026
Phase 3 (minimal Mongo ORM) proved the contract shape. Comparative analysis with the SQL ORM revealed the Collection chaining API, CollectionState, and row type inference are shared architectural patterns. Record this finding: - ADR 4: shared Collection interface with fluent chaining, family- specific compilation at terminal methods, spike-then-extract approach - Cross-cutting learning #6: shared ORM surface enumeration - Mongo Overview: Phase 3 complete, DQ #7 resolved, ADR 4 referenced - PoC plan: Phase 3 moved to completed, Phase 4 rewritten for Collection interface direction
jkomyno
pushed a commit
that referenced
this pull request
Apr 1, 2026
…arget Polymorphism is a cross-family concern — SQL needs single-table inheritance and enum-discriminated rows, MongoDB needs polymorphic collections, embedded fields, and mixed-type arrays. Both require discriminated unions in the contract type system. Rewrites design question #6 to cover both families with concrete storage mapping patterns and defines minimum April validation scope: contract can express discriminated unions, emitter produces narrowed TS types, ORM queries return narrowed types, STI storage mapping works for both families.
jkomyno
pushed a commit
that referenced
this pull request
Apr 1, 2026
Promote design principles (self-describing domain model, domain/persistence separation, scoped family details, facts-not-instructions) to cross-cutting learnings. Update contract-symmetry with domain/storage separation proposal. Update design questions #1 (embedding as relation property), #6 (discriminator + variants), #10 (domain level as shared contract surface) with concrete design answers. Update overview with redesign summary.
jkomyno
pushed a commit
that referenced
this pull request
Apr 1, 2026
jkomyno
pushed a commit
that referenced
this pull request
Apr 1, 2026
Phase 3 (minimal Mongo ORM) proved the contract shape. Comparative analysis with the SQL ORM revealed the Collection chaining API, CollectionState, and row type inference are shared architectural patterns. Record this finding: - ADR 4: shared Collection interface with fluent chaining, family- specific compilation at terminal methods, spike-then-extract approach - Cross-cutting learning #6: shared ORM surface enumeration - Mongo Overview: Phase 3 complete, DQ #7 resolved, ADR 4 referenced - PoC plan: Phase 3 moved to completed, Phase 4 rewritten for Collection interface direction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.