TML-2584: close out contract-ir-planes — migrate ADR 221, strip scaffolding#643
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (30)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughADR 221 was finalized to Accepted, documenting a two‑plane Contract IR with a canonical entity coordinate and pack‑contributed entity kinds; drive retro findings were updated with a new planning correction entry and a clarified note about mid‑flight slice collapsing. ChangesArchitecture and planning documentation updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Synthesise the project-level retro (invariant I10) into projects/contract-ir-planes/retros.md and land the narrow-and-defer planning win as a durable trial-findings stanza. Per-slice lessons already landed continuously during delivery; this captures the project-as-a-whole view ahead of close-out. Signed-off-by: Will Madden <madden@prisma.io>
Lift the durable contract-IR architectural decisions (two planes, uniform entity coordinate, pack-contributed entity-kind mechanism) out of the closing project folder into the ADR root. Strip project-shaping voice, transient projects/ paths, and slice/dispatch IDs per close-out prose-audit; status set to Accepted. Signed-off-by: Will Madden <madden@prisma.io>
The contract-ir-planes sub-project closes; re-point the umbrella plan/spec and the retro findings log at the migrated ADR 221 (and drop the transient spec/plan links that vanish with the folder) so no reference dangles after deletion. Signed-off-by: Will Madden <madden@prisma.io>
All slices merged, durable decisions migrated to ADR 221, deferred items ticketed (TML-2743/2744/2745), references re-pointed. Transient project scaffolding removed. Signed-off-by: Will Madden <madden@prisma.io>
Lead with a grounding contract example and the decision, build the reasoning up one idea per section, and move all rejected options to the end. Remove ticket/PR references and refactor-state framing (the slot-key-field option is reframed as a rejected alternative rather than something built and torn out). Signed-off-by: Will Madden <madden@prisma.io>
wmadden
force-pushed
the
tml-2584-contract-ir-planes-closeout
branch
from
f95ef37 to
ecc0347
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
Close-out for the contract-ir-planes sub-project (the contract IR two-plane reshape + uniform entity coordinate + pack-contributed entity-kind mechanism, with Postgres enum migrated onto the pack-contribution path). All slices have merged; this PR preserves the durable knowledge and removes the transient scaffolding.
Scope is docs / project-folder only — no source changes.
Project DoD verification
fixtures:checkgreen on merged slicesNamespace {id,kind}; clean-removable helpers deletedelementCoordinateswalk consumeddeserializeContract<T>generic0001-contract-planes→ ADR 221 (status: Accepted)Mandatory final retro (invariant I10): complete — synthesised in the close-out commit
docs(drive): mandatory final retroand landed as a durable trial-findings stanza (drive/retro/findings.md).Migration summary
1 long-lived file migrated; everything else under
projects/contract-ir-planes/was transient and deleted.projects/contract-ir-planes/adrs/0001-contract-planes.md→docs/architecture docs/adrs/ADR 221 - Contract IR two planes with uniform entity coordinate and pack-contributed entity kinds.mdprojects/…paths, slice/dispatch IDs, and the findings pointer; sibling links fixed; status set to Accepted.Reference-strip summary
3 files re-pointed, 0 dangling references remaining (
git grep "projects/contract-ir-planes/"outside the deleted folder returns empty):projects/target-extensible-ir-namespaces/plan.md— umbrella references to S1's spec/plan re-pointed at ADR 221; S1 noted closed.projects/target-extensible-ir-namespaces/spec.md— same.drive/retro/findings.md— historical co-ship-win prose softened to drop the transient path.Deferred scope (durably ticketed)
SqlModelStoragecoordinate → deletefindSqlTable+assertUniqueSqlTableNamesstripNamespaceKindsUnboundTablesLinear
Closes the close-out task for TML-2584. The umbrella project (
target-extensible-ir-namespaces) remains open — S2/S3 are still ahead.Summary by CodeRabbit