TML-2841: coordinate-addressing project scaffold — poly variant resolution by namespace coordinate#739
Draft
tensordreams wants to merge 2 commits into
Conversation
Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
…/ PR #720) Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Scaffolds the sql-orm-client coordinate addressing project (
projects/sql-orm-coordinate-addressing/): migrate the ORM off its module-wide default-namespace pin onto the ADR 221 entity coordinate(plane, namespaceId, entityKind, entityName).Origin: the TML-2683 review surfaced that polymorphic variant resolution is namespace-flat (TML-2841); investigation showed the pin is module-wide —
modelsOf()→domainModelsAtDefaultNamespace()throws on any contract with >1 namespace — so the operator promoted it to a three-slice project:PolymorphismInfo/VariantColumnRefcarry{namespace, table})..include()road honorsrel.to.namespace.Relationship to #720 (TML-2816, explicit-namespace-dsl)
#720 already delivers the namespace-scoped front door (
modelsOf(contract, namespaceId), the multi-namespace throw retired), namespace-qualified metadata caches, and collection-level namespace threading — which dissolves most of slice 3's original scope and provides exactly the plumbing slice 1 consumes. The plan in this PR records that re-anchoring; all three tickets are marked blocked-by TML-2816. Slice 1's sharpened claim: per-namespace-scoped lookups make cross-namespace variant resolution more wrong-by-construction (variants get looked up only in the base's namespace), which is precisely the gap this project closes on top of #720.Contents
projects/sql-orm-coordinate-addressing/spec.md(purpose, non-goals, cross-cutting requirements, project DoD) +plan.md(slice composition, sequencing rationale — the front-door throw is load-bearing and is retired last). Docs only; no code.