Skip to content

TML-2841: coordinate-addressing project scaffold — poly variant resolution by namespace coordinate#739

Draft
tensordreams wants to merge 2 commits into
mainfrom
tml-2841-sql-orm-polymorphic-variant-resolution-is-namespace-flat
Draft

TML-2841: coordinate-addressing project scaffold — poly variant resolution by namespace coordinate#739
tensordreams wants to merge 2 commits into
mainfrom
tml-2841-sql-orm-polymorphic-variant-resolution-is-namespace-flat

Conversation

@tensordreams
Copy link
Copy Markdown
Contributor

Draft / parked. Project scaffold only — implementation is blocked by #720 (TML-2816, explicit-namespace-dsl), which rewrites the same sql-orm-client resolution layer this project builds on. Work resumes once #720 merges.

What

Scaffolds the sql-orm-client coordinate addressing project (projects/sql-orm-coordinate-addressing/): migrate the ORM off its module-wide default-namespace pin onto the ADR 221 entity coordinate (plane, namespaceId, entityKind, entityName).

Origin: the TML-2683 review surfaced that polymorphic variant resolution is namespace-flat (TML-2841); investigation showed the pin is module-wide — modelsOf()domainModelsAtDefaultNamespace() throws on any contract with >1 namespace — so the operator promoted it to a three-slice project:

  1. TML-2841 — polymorphism resolution by coordinate (the irreducible core: a poly base in namespace A with a variant in namespace B; PolymorphismInfo/VariantColumnRef carry {namespace, table}).
  2. TML-2845 — relation/.include() road honors rel.to.namespace.
  3. TML-2846 — residue sweep + grep gate + multi-namespace project-DoD integration pass.

Relationship to #720 (TML-2816, explicit-namespace-dsl)

#720 already delivers the namespace-scoped front door (modelsOf(contract, namespaceId), the multi-namespace throw retired), namespace-qualified metadata caches, and collection-level namespace threading — which dissolves most of slice 3's original scope and provides exactly the plumbing slice 1 consumes. The plan in this PR records that re-anchoring; all three tickets are marked blocked-by TML-2816. Slice 1's sharpened claim: per-namespace-scoped lookups make cross-namespace variant resolution more wrong-by-construction (variants get looked up only in the base's namespace), which is precisely the gap this project closes on top of #720.

Contents

projects/sql-orm-coordinate-addressing/spec.md (purpose, non-goals, cross-cutting requirements, project DoD) + plan.md (slice composition, sequencing rationale — the front-door throw is load-bearing and is retired last). Docs only; no code.

Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
…/ PR #720)

Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 3aa7c361-d0b9-4c52-bbfa-5680d5e8838e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tml-2841-sql-orm-polymorphic-variant-resolution-is-namespace-flat

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant