Skip to content

pass hostname to tls_handshake#62

Merged
pimeys merged 2 commits intomasterfrom
verify-hostname
Jun 24, 2020
Merged

pass hostname to tls_handshake#62
pimeys merged 2 commits intomasterfrom
verify-hostname

Conversation

@esheppa
Copy link
Copy Markdown
Contributor

@esheppa esheppa commented Jun 17, 2020

No description provided.

@esheppa esheppa requested a review from pimeys June 24, 2020 12:42
Copy link
Copy Markdown
Contributor

@pimeys pimeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good? What was the problem originally with this and why it works now?

@esheppa
Copy link
Copy Markdown
Contributor Author

esheppa commented Jun 24, 2020

Good question, prior to this change it wasn't possible to connect to Azure SQL with TrustServerCertificate=no as the TLS connect function didn't have a hostname to compare against the server's certificate

@pimeys pimeys merged commit 422200d into master Jun 24, 2020
@pimeys pimeys deleted the verify-hostname branch June 24, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants