Skip to content

fix(site): update shell with dev settings#7679

Merged
mhartington merged 1 commit intomainfrom
shell-updates
Mar 20, 2026
Merged

fix(site): update shell with dev settings#7679
mhartington merged 1 commit intomainfrom
shell-updates

Conversation

@mhartington
Copy link
Copy Markdown
Member

@mhartington mhartington commented Mar 20, 2026

Summary by CodeRabbit

  • Refactor
    • Simplified internal URL handling by removing unused helper utilities and streamlining path management logic.
    • Reduced robots configuration to core rules, removing path-pattern exclusions previously managed through helper functions.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
blog Ready Ready Preview, Comment Mar 20, 2026 11:10am
docs Ready Ready Preview, Comment Mar 20, 2026 11:10am
eclipse Ready Ready Preview, Comment Mar 20, 2026 11:10am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cf4508a7-7fa7-4fa3-8c4d-a9c12a5bdfe2

📥 Commits

Reviewing files that changed from the base of the PR and between 6ce797f and a3506a3.

📒 Files selected for processing (2)
  • apps/site/src/app/robots.ts
  • apps/site/src/lib/url.ts
💤 Files with no reviewable changes (1)
  • apps/site/src/lib/url.ts

Walkthrough

The pull request removes blog-path handling utilities from the URL helpers library, including URL normalization, blog prefix wrapping, and active-link detection functions. The robots configuration is simultaneously simplified to eliminate blog path filtering.

Changes

Cohort / File(s) Summary
URL Utilities Removal
apps/site/src/lib/url.ts
Removed 6 exported functions: normalize(), withBlogBasePath(), withBlogBasePathForImageSrc(), isActive(), isActiveAny(), and constant BLOG_PREFIX. Only getBaseUrl() remains. This eliminates path normalization, blog-prefix rewriting, and active-link comparison logic from the module.
Robots Configuration Simplification
apps/site/src/app/robots.ts
Removed withBlogBasePath import and computed disallow patterns. Simplified allow rule to literal "/" and disallow array to only include legacyDisallow, eliminating blog path-specific filtering from robots rules.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'update shell with dev settings' does not clearly relate to the actual changes: removal of URL helper functions and robots.ts configuration updates. Revise the title to accurately reflect the main change, such as 'refactor: remove URL helper functions and simplify robots configuration' or 'refactor(site): clean up URL utilities and robots rules'.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@argos-ci
Copy link
Copy Markdown

argos-ci Bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 1 changed Mar 20, 2026, 11:15 AM

@mhartington mhartington merged commit 7cfc20d into main Mar 20, 2026
11 of 12 checks passed
@mhartington mhartington deleted the shell-updates branch March 20, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant