Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughA new MDX blog post is added announcing the deprecation of Prisma Optimize and introducing Query Insights in Prisma Postgres; the post contains full frontmatter metadata, explanatory content, dashboard GIF/screenshots, lessons learned, and migration steps for existing Optimize users. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/blog/content/blog/sunsetting-prisma-optimise/index.mdx`:
- Line 60: The sentence "Query Insights will soon be launching more broadly, and
it is available as part of **Prisma Postgres** without extra setup." is
contradictory; choose a single clear rollout state and update that sentence
accordingly—for example replace it with "Query Insights is available now as part
of Prisma Postgres without extra setup; broader rollout will follow soon."
Ensure the edited sentence in the blog content reflects the chosen state
(available now vs. coming soon) and keeps the bolding for Prisma Postgres if
desired.
- Line 3: The frontmatter slug value currently uses British spelling
"sunsetting-prisma-optimise"; update the slug to use the product's canonical
name by replacing the slug value "sunsetting-prisma-optimise" with
"sunsetting-prisma-optimize" in the file (update the slug field so internal
links and search use the canonical "Optimize" spelling).
- Around line 53-58: The migration snippet removes the extension call but
doesn't instruct removing the now-unused import; update the example so after
deleting the .$extends(withOptimize()) call you also remove the corresponding
import (withOptimize) and any references to it (e.g., from the PrismaClient
import or top-of-file import statement), then run a quick TypeScript/ESLint
check to ensure no dead/import errors remain; target symbols: PrismaClient and
withOptimize.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cd952600-f827-43db-a5c0-b02da15cae80
⛔ Files ignored due to path filters (3)
apps/blog/public/sunsetting-prisma-optimise/imgs/optimize-sunset.svgis excluded by!**/*.svgapps/blog/public/sunsetting-prisma-optimise/imgs/optimize-sunset@2x.pngis excluded by!**/*.pngapps/blog/public/sunsetting-prisma-optimise/imgs/query-insights.gifis excluded by!**/*.gif
📒 Files selected for processing (1)
apps/blog/content/blog/sunsetting-prisma-optimise/index.mdx
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
apps/blog/content/blog/sunsetting-prisma-optimize/index.mdx (2)
54-54:⚠️ Potential issue | 🟡 MinorClarify rollout status to avoid contradictory messaging.
Line 54 states Query Insights "will soon be launching more broadly" while also saying it "is available." This creates ambiguity for readers trying to understand whether they can use it today or need to wait.
Choose one clear state: either it's available now (for Prisma Postgres users) with broader rollout coming, or it's coming soon. The current phrasing contradicts itself.
💡 Suggested revision
-Query Insights will soon be launching more broadly, and it is available as part of **Prisma Postgres** without extra setup. +Query Insights is available now as part of **Prisma Postgres** without extra setup, and will be launching more broadly soon.or
-Query Insights will soon be launching more broadly, and it is available as part of **Prisma Postgres** without extra setup. +Query Insights is available now as part of **Prisma Postgres** without extra setup. Broader rollout will follow soon.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/blog/content/blog/sunsetting-prisma-optimize/index.mdx` at line 54, The sentence mentioning "Query Insights" currently mixes two states ("will soon be launching more broadly" and "is available"), creating contradictory messaging; edit the line containing "Query Insights" and "Prisma Postgres" to express a single clear state—either state it is available now for Prisma Postgres users and note broader rollout is coming, or state it is coming soon and remove "is available" wording—so update the copy to one unambiguous sentence referencing "Query Insights" and "Prisma Postgres" accordingly.
49-51:⚠️ Potential issue | 🟠 MajorMigration snippet is incomplete for copy-paste users.
The code snippet removes the
.$extends(withOptimize())call but doesn't show removing the corresponding import. Readers following this literally may leave dead imports in their codebase, which can cause linting errors or confusion.📝 Proposed fix
+import { PrismaClient } from '@prisma/client' -import { withOptimize } from '@prisma/extension-optimize' const prisma = new PrismaClient() .$extends(withOptimize()) // [!code --]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/blog/content/blog/sunsetting-prisma-optimize/index.mdx` around lines 49 - 51, The code snippet shows removing ".$extends(withOptimize())" but doesn't remove the corresponding import; locate the import statement that brings in withOptimize (e.g., an `import { withOptimize } from ...` or `const { withOptimize } = ...`) and remove it or update the example to show both the removed call and the removed import so readers don't end up with a dead/unused import alongside PrismaClient; ensure references to the symbol withOptimize are fully removed from the snippet and any example code blocks.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/blog/content/blog/sunsetting-prisma-optimize/index.mdx`:
- Line 20: Update the sentence shown in the diff ("In recent rounds of user
feedback, we asked users of Optmize what their pain points where with the
feature.") by correcting the two typos: change "Optmize" to "Optimize" and
change "where" to "were" so the sentence reads "In recent rounds of user
feedback, we asked users of Optimize what their pain points were with the
feature."
---
Duplicate comments:
In `@apps/blog/content/blog/sunsetting-prisma-optimize/index.mdx`:
- Line 54: The sentence mentioning "Query Insights" currently mixes two states
("will soon be launching more broadly" and "is available"), creating
contradictory messaging; edit the line containing "Query Insights" and "Prisma
Postgres" to express a single clear state—either state it is available now for
Prisma Postgres users and note broader rollout is coming, or state it is coming
soon and remove "is available" wording—so update the copy to one unambiguous
sentence referencing "Query Insights" and "Prisma Postgres" accordingly.
- Around line 49-51: The code snippet shows removing ".$extends(withOptimize())"
but doesn't remove the corresponding import; locate the import statement that
brings in withOptimize (e.g., an `import { withOptimize } from ...` or `const {
withOptimize } = ...`) and remove it or update the example to show both the
removed call and the removed import so readers don't end up with a dead/unused
import alongside PrismaClient; ensure references to the symbol withOptimize are
fully removed from the snippet and any example code blocks.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e829572f-4d37-4a20-a7e3-1481c12a8d40
📒 Files selected for processing (1)
apps/blog/content/blog/sunsetting-prisma-optimize/index.mdx
Apply review feedback to the Optimize sunset post by fixing copy typos, clarifying Query Insights rollout wording, and improving the migration diff to remove the unused Optimize import. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit