Skip to content

MSSQL and db command#942

Merged
mhwelander merged 99 commits intomasterfrom
mssql-preview
Oct 27, 2020
Merged

MSSQL and db command#942
mhwelander merged 99 commits intomasterfrom
mssql-preview

Conversation

@mhwelander
Copy link
Copy Markdown
Contributor

No description provided.

mhwelander added 30 commits May 26, 2020 17:20
Fixed some typos
* The `license_number` field has a `UNIQUE` constraint
* The `license_number` field only allows **one** `NULL` value

The standard way to get around this issue is to create a filtered unique index that excludes `NULL` values. This allows you to insert multiple `NULL` values. If you do not create an index in the database, you will get an error if you try to insert more than one `null` value into a column with Prisma Client.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thebiglabasky should we mention that partial indices are not visible in the introspected data model, even when just doing WHERE key IS NOT NULL. This should be available later, but I can't find the ticket for now. We should maybe find it or create a new one, so people can follow the progress...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a docs GH issue for this to remind myself in case we squash-merge before answering this

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'd be ideal indeed

mhwelander and others added 3 commits October 27, 2020 15:30
…index.mdx

Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
…es/001-sql-server/index.mdx

Co-authored-by: Julius de Bruijn <bruijn@prisma.io>
mhwelander and others added 2 commits October 27, 2020 15:35
…command-reference.mdx

Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
Copy link
Copy Markdown
Contributor

@albertoperdomo albertoperdomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed documentation on db push. Left some suggestions and comments.

@2color
Copy link
Copy Markdown
Contributor

2color commented Oct 27, 2020

Some users will already have an existing database. I'd suggest adjusting the "Start from scratch with SQL Server" guide and inform users that they can skip the step where the database is created with SQL.

@mhwelander mhwelander merged commit 08db4af into master Oct 27, 2020
@mhwelander mhwelander deleted the mssql-preview branch October 27, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MSSQL

7 participants